Skip to content

Move tenant-related utils to common folder#1184

Merged
cliu123 merged 3 commits intoopensearch-project:mainfrom
cliu123:move_utils_to_common_folder
Nov 2, 2022
Merged

Move tenant-related utils to common folder#1184
cliu123 merged 3 commits intoopensearch-project:mainfrom
cliu123:move_utils_to_common_folder

Conversation

@cliu123
Copy link
Member

@cliu123 cliu123 commented Nov 2, 2022

Description

[Describe what this change achieves]

Category

[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation] Refactoring

Why these changes are required?

What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve (Is this a backport? If so, please add backport PR # and/or commits #)]

Testing

UT, IT, Cypress tests

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cliu123
Move utils to common folder
abfae9a 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@cliu123
Remove the unnecessary export tenantColumn in public/index.js
0e1178b 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@cliu123 cliu123 requested a review from a team November 2, 2022 20:11
@cliu123
Copy link
Member Author

cliu123 commented Nov 2, 2022

@kavilla Please test these changes with the build script and see if they unblock you. Thanks!

@cliu123 cliu123 added the v2.4.0 'Issues and PRs related to version v2.4.0' label Nov 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2022 •
edited by codecov bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.80%. Comparing base (d46e60a) to head (30fd8f5).
⚠️ Report is 262 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1184      +/-   ##
==========================================
- Coverage   71.82%   71.80%   -0.02%     
==========================================
  Files          88       88              
  Lines        2023     2011      -12     
  Branches      268      270       +2     
==========================================
- Hits         1453     1444       -9     
+ Misses        508      505       -3     
  Partials       62       62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cliu123
Move globalTenantName to common
30fd8f5 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
@cliu123
Copy link
Member Author

cliu123 commented Nov 2, 2022

@kavilla confirmed that this PR resolved the release build failures. Thanks for finding and bringing up this issue!
@opensearch-project/security Please review. Thanks!

@cliu123 cliu123 mentioned this pull request Nov 2, 2022
Closed
@cwperks
Copy link
Member

cwperks commented Nov 2, 2022 •
edited
Loading

@cliu123 @kavilla Is it possible to add a new check to validate this as part of the CI?

@RyanL1997
Copy link
Collaborator

RyanL1997 commented Nov 2, 2022 •
edited
Loading

@cliu123 @kavilla Is it possible to add a new check to validate this as part of the CI?

Same question from me, if we can figure out a solution for check with our own build, that would also be helpful on create our own reusable CI workflow as this issue(#1156) mentioned.

@cliu123 cliu123 merged commit f815e3c into opensearch-project:main Nov 2, 2022
@cliu123 cliu123 deleted the move_utils_to_common_folder branch November 2, 2022 21:37
@cliu123
Copy link
Member Author

cliu123 commented Nov 2, 2022

created an issue to track the follow-up action items: #1169

cliu123 added a commit to cliu123/security-dashboards-plugin that referenced this pull request Nov 3, 2022
@cliu123
Move tenant-related utils to common folder (opensearch-project#1184)
7e2a07c 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit f815e3c)
@cliu123 cliu123 mentioned this pull request Nov 3, 2022
Merged
cliu123 added a commit to cliu123/security-dashboards-plugin that referenced this pull request Nov 3, 2022
@cliu123
Move tenant-related utils to common folder (opensearch-project#1184)
e7f9d49 
Signed-off-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit f815e3c)
@cliu123 cliu123 mentioned this pull request Nov 3, 2022
Merged
peternied pushed a commit that referenced this pull request Nov 3, 2022
@cliu123 @RyanL1997
@cwperks @zengyan-amazon
[Backport 2.4] OSD Saved Object Aggregation View (#1187)
5d98892 
* Saved Object Aggregation View (#1146)
* Move tenant-related utils to common folder (#1184)
* [Saved Object Aggregation View] Use namespace registry to add tenant filter (#1169)

Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Yan Zeng <zengyan@amazon.com>

Co-authored-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
Co-authored-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Yan Zeng <zengyan@amazon.com>
peternied pushed a commit that referenced this pull request Nov 3, 2022
@cliu123 @RyanL1997
@cwperks @zengyan-amazon
[Backport 2.x] OSD Saved Object Aggregation View (#1186)
ccb3ccd 
* Saved Object Aggregation View (#1146)
* Move tenant-related utils to common folder (#1184)
* [Saved Object Aggregation View] Use namespace registry to add tenant filter (#1169)

Signed-off-by: Chang Liu <lc12251109@gmail.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Yan Zeng <zengyan@amazon.com>

Co-authored-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
Co-authored-by: Craig Perkins <cwperx@amazon.com>
Co-authored-by: Yan Zeng <zengyan@amazon.com>
@peternied peternied mentioned this pull request Jul 19, 2023
Merged
3 tasks
@Desvelao Desvelao mentioned this pull request Oct 27, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwperks cwperks cwperks approved these changes

@RyanL1997 RyanL1997 RyanL1997 approved these changes

Assignees

No one assigned

Labels

v2.4.0 'Issues and PRs related to version v2.4.0'

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cliu123 @codecov-commenter @cwperks @RyanL1997