Fixed the tenant switching after timeout by RyanL1997 · Pull Request #1090 · opensearch-project/security-dashboards-plugin

RyanL1997 · 2022-08-31T14:33:51Z

Signed-off-by: Ryan Liang jiallian@amazon.com

Description

Fix the issue of user tenant automatically switch back to Private/Global by default after session timeout.

Issues Resolved

Resolved [BUG] Tenant keeps switching to Global #1084

Check List

New functionality includes testing
~~New functionality has been documented~~
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks

Looks good. Thanks @RyanL1997!

peternied

Need to add tests to verify this change

public/plugin.ts

cliu123 · 2022-09-06T20:09:31Z

@RyanL1997 Could you please add the manual testing in the PR description for now and add ITs in a follow up PR if adding ITs will take time?

codecov-commenter · 2022-09-06T20:39:30Z

Codecov Report

Merging #1090 (0036ccd) into main (d89d31b) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   72.27%   72.43%   +0.16%     
==========================================
  Files          87       88       +1     
  Lines        1915     1919       +4     
  Branches      244      246       +2     
==========================================
+ Hits         1384     1390       +6     
+ Misses        478      474       -4     
- Partials       53       55       +2

Impacted Files	Coverage Δ
...lugins/security-dashboards-plugin/public/plugin.ts	`0.00% <0.00%> (ø)`
...ty-dashboards-plugin/public/utils/logout-utils.tsx	`66.66% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

peternied

Thanks for adding the tests - a couple of comments about theses and I think we should add another test case

public/utils/logout-utils.tsx

public/apps/account/test/plugin.test.tsx

public/utils/logout-utils.tsx

public/apps/account/test/plugin.test.tsx

public/utils/logout-utils.tsx

peternied

Looks good, I think you'll need to rebase 2.4.0 has merged otherwise intergration tests aren't going to work

peternied · 2022-09-12T21:19:24Z

See #1096

RyanL1997 · 2022-09-12T21:23:02Z

@RyanL1997 Could you please add the manual testing in the PR description for now and add ITs in a follow up PR if adding ITs will take time?

@cliu123 Sorry for the late reply. I have been working on the unit tests and I just updated the PR with automation tests cases.

RyanL1997 · 2022-09-12T21:25:23Z

Looks good, I think you'll need to rebase 2.4.0 has merged otherwise intergration tests aren't going to work

@peternied Got it! Thank you again for the review!

DarshitChanpura

Looks good Ryan. Can you please rebase it with https://github.com/cwperks/security-dashboards-plugin/tree/increment-to-2.4.0.0 so ITs can work

RyanL1997 · 2022-09-13T20:40:10Z

Looks good Ryan. Can you please rebase it with https://github.com/cwperks/security-dashboards-plugin/tree/increment-to-2.4.0.0 so ITs can work

@DarshitChanpura I just did the rebase and pushed. Thx DC!

cliu123 · 2022-09-13T20:48:39Z

@RyanL1997 The rebase was not done properly. The version bump changes are not supposed to be present in this PR.

Signed-off-by: Ryan Liang <jiallian@amazon.com>

RyanL1997 · 2022-09-14T14:47:05Z

@RyanL1997 The rebase was not done properly. The version bump changes are not supposed to be present in this PR.

Hi @cliu123, ty for the review, and I just fixed this.

DarshitChanpura

Ty @RyanL1997 !

Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 5d018b0)

Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 5d018b0) Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>

Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>

RyanL1997 requested a review from a team August 31, 2022 14:33

RyanL1997 marked this pull request as draft August 31, 2022 21:31

RyanL1997 force-pushed the bug-1084 branch 3 times, most recently from 8f2521d to a9c1f3e Compare August 31, 2022 23:54

RyanL1997 marked this pull request as ready for review September 1, 2022 01:00

cliu123 previously approved these changes Sep 1, 2022

View reviewed changes

cwperks previously approved these changes Sep 2, 2022

View reviewed changes

cwperks added the backport 2.x backport to 2.x branch label Sep 2, 2022

expani mentioned this pull request Sep 5, 2022

SAML Integration Tests #1088

Merged

3 tasks

cwperks added the backport 1.3 label Sep 6, 2022

peternied requested changes Sep 6, 2022

View reviewed changes

public/plugin.ts Outdated Show resolved Hide resolved

RyanL1997 marked this pull request as draft September 12, 2022 15:47

RyanL1997 dismissed stale reviews from cwperks and cliu123 via 438e7ed September 12, 2022 16:33

RyanL1997 force-pushed the bug-1084 branch 2 times, most recently from 7b6bcf9 to 169abd6 Compare September 12, 2022 17:54

peternied requested changes Sep 12, 2022

View reviewed changes

RyanL1997 force-pushed the bug-1084 branch 2 times, most recently from 39bb689 to 1f8c84b Compare September 12, 2022 18:27

cwperks reviewed Sep 12, 2022

View reviewed changes

public/utils/logout-utils.tsx Outdated Show resolved Hide resolved

RyanL1997 force-pushed the bug-1084 branch 4 times, most recently from 5af7e6a to 03610fb Compare September 12, 2022 21:02

RyanL1997 marked this pull request as ready for review September 12, 2022 21:14

peternied previously approved these changes Sep 12, 2022

View reviewed changes

DarshitChanpura requested changes Sep 13, 2022

View reviewed changes

RyanL1997 dismissed peternied’s stale review via 0036ccd September 13, 2022 20:39

Fixed the tenant switching after timeout

c921fd7

Signed-off-by: Ryan Liang <jiallian@amazon.com>

RyanL1997 force-pushed the bug-1084 branch from 0036ccd to c921fd7 Compare September 14, 2022 14:12

DarshitChanpura approved these changes Sep 14, 2022

View reviewed changes

peternied approved these changes Sep 14, 2022

View reviewed changes

peternied merged commit 5d018b0 into opensearch-project:main Sep 14, 2022

opensearch-trigger-bot bot mentioned this pull request Sep 14, 2022

[Backport 1.3] Fixed the tenant switching after timeout #1102

Merged

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022

Fixed the tenant switching after timeout (#1090)

48fe6f7

Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 5d018b0)

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022

Fixed the tenant switching after timeout (#1090)

a5d6ee0

Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 5d018b0)

opensearch-trigger-bot bot mentioned this pull request Sep 14, 2022

[Backport 2.x] Fixed the tenant switching after timeout #1103

Merged

cwperks mentioned this pull request Sep 16, 2022

Fix for Tenancy info getting lost on re-login in SAML Authentication flow #1058

Merged

3 tasks

vinayak15 mentioned this pull request Oct 6, 2022

Release note 1.3.6 #1136

Merged

3 tasks

RyanL1997 deleted the bug-1084 branch December 6, 2022 19:14

Desvelao mentioned this pull request Oct 27, 2025

Merge 4.14.1 into main wazuh/wazuh-security-dashboards-plugin#400

Merged

1 task

Conversation

RyanL1997 commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Category

Issues Resolved

Check List

Uh oh!

cwperks left a comment

Choose a reason for hiding this comment

Uh oh!

peternied left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cliu123 commented Sep 6, 2022

Uh oh!

codecov-commenter commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peternied left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

peternied left a comment

Choose a reason for hiding this comment

Uh oh!

peternied commented Sep 12, 2022

Uh oh!

RyanL1997 commented Sep 12, 2022

Uh oh!

RyanL1997 commented Sep 12, 2022

Uh oh!

DarshitChanpura left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RyanL1997 commented Sep 13, 2022

Uh oh!

cliu123 commented Sep 13, 2022

Uh oh!

RyanL1997 commented Sep 14, 2022

Uh oh!

DarshitChanpura left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

RyanL1997 commented Aug 31, 2022 •

edited

Loading

codecov-commenter commented Sep 6, 2022 •

edited

Loading

DarshitChanpura left a comment •

edited

Loading