Add WLM workload group settings UI - #526
Merged
KishoreKicha14 merged 2 commits intoJun 1, 2026
Merged
Conversation
dzane17
force-pushed
the
wlm-group-settings
branch
from
May 27, 2026 00:30
de7692a to
cc4f9ee
Compare
Member
Author
|
Security check failure will be resolved by #527 |
dzane17
marked this pull request as ready for review
May 27, 2026 15:39
dzane17
requested review from
KishoreKicha14,
ansjcy,
deshsidd and
jainankitk
as code owners
May 27, 2026 15:39
dzane17
force-pushed
the
wlm-group-settings
branch
2 times, most recently
from
May 27, 2026 17:07
eada788 to
6dc4362
Compare
Collaborator
|
Collaborator
|
can you also fix the failing cypress tests? |
dzane17
force-pushed
the
wlm-group-settings
branch
from
May 27, 2026 21:01
6dc4362 to
09adbb9
Compare
Signed-off-by: David Zane <davizane@amazon.com>
dzane17
force-pushed
the
wlm-group-settings
branch
from
May 27, 2026 21:51
09adbb9 to
d986bd5
Compare
Member
Author
|
@KishoreKicha14 Good points
|
KishoreKicha14
approved these changes
Jun 1, 2026
KishoreKicha14
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Thanks @dzane17 for the PR..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds dashboard support for the per-workload-group
settingsblock introduced in OpenSearch 3.7 (#20536, #21143, #21523, #21721). Administrators can now set, update, and remove the six supported keys directly from the WLM Workload Management UI on both the create and edit flows.Documentation: opensearch-project/documentation-website#12444
What's new
A new
Group settingssection on the Settings tab of the WLM details page, mirrored as a panel on the create page. Each row carries the raw API key (search.max_buckets,override_request_values, etc.), a short description, aSettoggle, and a typed input.Things to note
isWlmGroupSettingsSupported(version)helper hides the section on data sources < 3.7, mirroring the existingisSecurityAttributesSupported≥ 3.3 pattern.search.max_buckets ≥ 0, time values match250ms/30s/1m, integers respect their per-key minimum. Invalid rows show an inline error and disableApply Changes. Constraints live in a single table (WLM_SETTING_DEFS) — adding a new key is a one-row append.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.