Add icons for OSD 2.10 release#1014
Merged
joshuarrrr merged 4 commits intoopensearch-project:mainfrom Sep 1, 2023
Merged
Conversation
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
AMoo-Miki,
BSFishy,
KrooshalUX,
SergeyMyssak,
andreymyssak,
ashwin-pc,
bandinib-amzn,
rednaksi91 and
seanneumann
as code owners
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
commented
Sep 1, 2023
| const OuiIconIntegrationObservability = ({ title, titleId, ...props }) => ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| viewBox="0 0 12 12" |
Member
Author
There was a problem hiding this comment.
@canascar Note that the integration* icons appear to have been created on a 12x12 canvas. For this reason, I left off any explicit width/height properties. It should work fine, but in the future, for consistency, all icons should be built to be 16x16 by default.
AMoo-Miki
reviewed
Sep 1, 2023
AMoo-Miki
approved these changes
Sep 1, 2023
Signed-off-by: Josh Romero <rmerqg@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Add icons for OSD 2.10 release Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * Fix naming of `integrationSecurity` icon Signed-off-by: Josh Romero <rmerqg@amazon.com> * Remove explicit height and width properties Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 64465b1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ashwin-pc
pushed a commit
that referenced
this pull request
Sep 1, 2023
* Add icons for OSD 2.10 release Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * Fix naming of `integrationSecurity` icon Signed-off-by: Josh Romero <rmerqg@amazon.com> * Remove explicit height and width properties Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 64465b1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Icon cleanup steps:
<xml>declarationsIssues Resolved
Fixes #873
Check List
yarn lintyarn test-unitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.