Skip to content

Add crossInCircleEmpty and power icons#1044

Merged
AMoo-Miki merged 3 commits intoopensearch-project:mainfrom
BSFishy:icons/activate
Sep 19, 2023
Merged

Add crossInCircleEmpty and power icons#1044
AMoo-Miki merged 3 commits intoopensearch-project:mainfrom
BSFishy:icons/activate

Conversation

@BSFishy
Copy link
Contributor

@BSFishy BSFishy commented Sep 18, 2023

Description

Add crossInCircleEmpty and power icons.

Screenshot (154)
Screenshot (155)

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • All tests pass
    • yarn lint
    • yarn test-unit
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Matt Provost <provomat@amazon.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's just remove the width and height.

Signed-off-by: Matt Provost <provomat@amazon.com>
@AMoo-Miki AMoo-Miki merged commit ad0ecb9 into opensearch-project:main Sep 19, 2023
@BSFishy BSFishy deleted the icons/activate branch September 19, 2023 16:53
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 19, 2023
* Add crossInCircleEmpty and power icons

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update changelog

Signed-off-by: Matt Provost <provomat@amazon.com>

* Remove width and height attributes

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit ad0ecb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this pull request Sep 19, 2023
* Add crossInCircleEmpty and power icons

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update changelog

Signed-off-by: Matt Provost <provomat@amazon.com>

* Remove width and height attributes

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
(cherry picked from commit ad0ecb9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants