-
Notifications
You must be signed in to change notification settings - Fork 9
Add compilation of python schema and service libraries #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
karenyrx
merged 49 commits into
opensearch-project:main
from
finnegancarroll:rules-proto-grpc-min-4.5
Jul 26, 2025
Merged
Add compilation of python schema and service libraries #114
karenyrx
merged 49 commits into
opensearch-project:main
from
finnegancarroll:rules-proto-grpc-min-4.5
Jul 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c14056a to
304f5bb
Compare
karenyrx
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
1fc7b53 to
fb7c323
Compare
|
Hi @karenyrx, any additional feedback for these changes? |
karenyrx
reviewed
Jul 21, 2025
4ed7222 to
ab28055
Compare
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…o/c/44OcoVSmeQk. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…mple - Java commented out. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…hot. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…fix for bazel 7.0. Signed-off-by: Finn Carroll <[email protected]>
…ion. Signed-off-by: Finn Carroll <[email protected]>
ab28055 to
a0c3674
Compare
Signed-off-by: Finn Carroll <[email protected]>
|
Hi @karenyrx, removed both patch files with some re-ordering and updated dependencies. |
karenyrx
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the Bazel libraries for the compilation of protobuf schema and service definitions into python libraries. These changes do not include any packaging or publishing for the python libraries.
A few major changes are included in this PR to facilitate python support:
Bazel 7 includes changes to the Bazel language which resolves syntax errors in code invoked by
rules_pythonwhich is necessary here. Higher versions of Bazel have migrated to Bazel Modules, to keep the existingWORKSPACEmodel bazelmod is disabled by default in.bazelrc.rule_proto_grpc.https://github.com/rules-proto-grpc/rules_proto_grpc
This actively maintained apache 2 licensed project provides support for multiple protobuf language rules. Java and python rules have been migrated to this project to avoid conflicting dependencies between each newly added language rule. Additionally dependencies have been removed from
maven_installwhere possible so Bazel http archives are the single source of truth for dependencies.Testing
Bazel commands
Docker stages for build/package/test
Note: The implementations in core are out of sync with this repo at the moment while this change is in flight.
If the OpenSearch version specified in the Dockerfile is updated to match this feature branch this
test-bazel-javastage passes.Note: Only a build stage for python is included in this version. Packaging and testing to be handled in follow up PRs.
Issues Resolved
#8
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.