-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[GRPC] Make transport-grpc extensible to other plugins #18516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Karen Xu <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #18516 +/- ##
============================================
+ Coverage 72.67% 72.76% +0.08%
- Complexity 68610 68683 +73
============================================
Files 5577 5582 +5
Lines 315375 315510 +135
Branches 45772 45789 +17
============================================
+ Hits 229209 229568 +359
+ Misses 67613 67357 -256
- Partials 18553 18585 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen Xu <[email protected]>
|
❌ Gradle check result for f5a2243: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
plugins/transport-grpc/src/main/java/org/opensearch/plugin/transport/grpc/GrpcPlugin.java
Show resolved
Hide resolved
...nsearch/plugin/transport/grpc/proto/request/search/query/AbstractQueryBuilderProtoUtils.java
Outdated
Show resolved
Hide resolved
...rch/plugin/transport/grpc/proto/request/search/query/QueryBuilderProtoConverterRegistry.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen X <[email protected]>
...nsearch/plugin/transport/grpc/proto/request/search/query/AbstractQueryBuilderProtoUtils.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
...rch/plugin/transport/grpc/proto/request/search/query/QueryBuilderProtoConverterRegistry.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 5732236: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f959e3e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen Xu <[email protected]>
|
❕ Gradle check result for 69e2eef: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…oject#18516) * [GRPC] Make transport-grpc extensible for other plugins Signed-off-by: Karen Xu <[email protected]> * more UTs for code cov Signed-off-by: Karen Xu <[email protected]> * upgrade to protobufs v0.4.0 and address comments Signed-off-by: Karen Xu <[email protected]> * convert to instance-level and fix changelog Signed-off-by: Karen Xu <[email protected]> * remove converter list and increase codecov Signed-off-by: Karen Xu <[email protected]> --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Karen Xu <[email protected]> Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: sunqijun.jun <[email protected]>
…oject#18516) * [GRPC] Make transport-grpc extensible for other plugins Signed-off-by: Karen Xu <[email protected]> * more UTs for code cov Signed-off-by: Karen Xu <[email protected]> * upgrade to protobufs v0.4.0 and address comments Signed-off-by: Karen Xu <[email protected]> * convert to instance-level and fix changelog Signed-off-by: Karen Xu <[email protected]> * remove converter list and increase codecov Signed-off-by: Karen Xu <[email protected]> --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Karen Xu <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
…oject#18516) * [GRPC] Make transport-grpc extensible for other plugins Signed-off-by: Karen Xu <[email protected]> * more UTs for code cov Signed-off-by: Karen Xu <[email protected]> * upgrade to protobufs v0.4.0 and address comments Signed-off-by: Karen Xu <[email protected]> * convert to instance-level and fix changelog Signed-off-by: Karen Xu <[email protected]> * remove converter list and increase codecov Signed-off-by: Karen Xu <[email protected]> --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Karen Xu <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
Description
This PR refactors the GRPC transport module to provide extension points for plugins. The goal is to make it possible for third-party and internal plugins to register custom GRPC services, enhancing the flexibility and extensibility of the transport layer.
Test plan
./gradlew :plugins:transport-grpc:testRelated Issues
#18513
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.