Skip to content

remove sub working directory for gantt-chart#4375

Merged
prudhvigodithi merged 3 commits intoopensearch-project:mainfrom
joshuali925:flatten-repo
Feb 5, 2024
Merged

remove sub working directory for gantt-chart#4375
prudhvigodithi merged 3 commits intoopensearch-project:mainfrom
joshuali925:flatten-repo

Conversation

@joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jan 26, 2024

Description

after opensearch-project/dashboards-visualizations#321, there will be no need to specify build script and working directory.

This is tested on fork using ./build.sh manifests/3.0.0/opensearch-dashboards-3.0.0.yml --component OpenSearch-Dashboards ganttChartDashboards. tested on 3.0.0, 2.12.0, 1.3.14

Note

In all future release versions (>=3.0.0, >=2.12.0, >=1.3.15), the manifest file should not include working_directory: gantt-chart. This seems to be done manually (e.g. #4264). cc. @zelinh


Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@codecov
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88b16f9) 91.35% compared to head (220c109) 91.35%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4375   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         190      190           
  Lines        6197     6197           
=======================================
  Hits         5661     5661           
  Misses        536      536           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 marked this pull request as draft January 26, 2024 00:17
@joshuali925
Copy link
Member Author

joshuali925 commented Jan 26, 2024

converting to draft until opensearch-project/dashboards-visualizations#321 gets merged

Edit: pending backports opensearch-project/dashboards-visualizations#323, opensearch-project/dashboards-visualizations#325

Edit: removed draft status since all PRs are merged in dashboards-visualizations

Copy link
Contributor

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, do we want to make the change for 2.12?

@joshuali925
Copy link
Member Author

Nice, do we want to make the change for 2.12?

replied in opensearch-project/dashboards-visualizations#321 (comment)

@vamsimanohar
Copy link
Member

LGTM

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 marked this pull request as ready for review February 1, 2024 00:00
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prudhvigodithi Any objections to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants