remove sub working directory for gantt-chart#4375
remove sub working directory for gantt-chart#4375prudhvigodithi merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4375 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6197 6197
=======================================
Hits 5661 5661
Misses 536 536 ☔ View full report in Codecov by Sentry. |
|
converting to draft until opensearch-project/dashboards-visualizations#321 gets merged Edit: pending backports opensearch-project/dashboards-visualizations#323, opensearch-project/dashboards-visualizations#325 Edit: removed draft status since all PRs are merged in dashboards-visualizations |
derek-ho
left a comment
There was a problem hiding this comment.
Nice, do we want to make the change for 2.12?
replied in opensearch-project/dashboards-visualizations#321 (comment) |
|
LGTM |
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
gaiksaya
left a comment
There was a problem hiding this comment.
@prudhvigodithi Any objections to merge this?
Description
after opensearch-project/dashboards-visualizations#321, there will be no need to specify build script and working directory.
This is tested on fork using
./build.sh manifests/3.0.0/opensearch-dashboards-3.0.0.yml --component OpenSearch-Dashboards ganttChartDashboards. tested on 3.0.0, 2.12.0, 1.3.14Note
In all future release versions (>=3.0.0, >=2.12.0, >=1.3.15), the manifest file should not include
working_directory: gantt-chart. This seems to be done manually (e.g. #4264). cc. @zelinhIssues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.