Add rest of components to 1.3.14 manifest#4264
Merged
zelinh merged 3 commits intoopensearch-project:mainfrom Dec 4, 2023
Merged
Add rest of components to 1.3.14 manifest#4264zelinh merged 3 commits intoopensearch-project:mainfrom
zelinh merged 3 commits intoopensearch-project:mainfrom
Conversation
zelinh
requested review from
Divyaasm,
bbarani,
dblock,
gaiksaya,
jordarlu,
peterzhuamazon,
prudhvigodithi,
rishabh6788 and
tianleh
as code owners
Member
Author
|
This PR will be merged once we get response from opensearch-project/sql#2129 and have that PR merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4264 +/- ##
=======================================
Coverage 93.16% 93.16%
=======================================
Files 189 189
Lines 5973 5973
=======================================
Hits 5565 5565
Misses 408 408 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
force-pushed
the
add-all-components
branch
from
4f5716b to
374f273
Compare
peterzhuamazon
approved these changes
Dec 4, 2023
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
zelinh
force-pushed
the
add-all-components
branch
from
d18ced7 to
4d7f00a
Compare
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
peterzhuamazon
approved these changes
Dec 4, 2023
Member
peterzhuamazon
left a comment
peterzhuamazon
left a comment
There was a problem hiding this comment.
Worked with @zelinh to fix the manifests.yml issues that fail-fast section should be placed under strategy.
Also, remove the pull_request paths condition as the list-changed-manifests: workflow already checking that. If nothing exist the matrix on the next will simply ignore.
Thanks.
Member
Author
|
Merging this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add rest of components to 1.3.14 manifest
Issues Resolved
Part of #4069
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.