Skip to content

Fix Notification Dashboards build issues #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qreshi merged 3 commits into from
Apr 8, 2022
Merged

Fix Notification Dashboards build issues #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2014a21
Update enzyme-adapter-react-16 to 1.15.5 and cypress to 6.0.0
qreshi Apr 8, 2022
52b4ce1
Update yarn.lock
qreshi Apr 8, 2022
67d49eb
Update Jest snapshots
qreshi Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dashboards-notifications/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@
"plugin_helpers": "node ../../scripts/plugin_helpers"
},
"dependencies": {
"cypress": "^5.0.0"
"cypress": "^6.0.0"
},
"devDependencies": {
"@types/enzyme-adapter-react-16": "^1.0.6",
"@types/showdown": "^1.9.3",
"enzyme-adapter-react-16": "^1.15.2",
"enzyme-adapter-react-16": "^1.15.5",
"jest": "^27.5.1",
"jest-dom": "^4.0.0"
}
Expand Down
4 changes: 2 additions & 2 deletions ...boards-notifications/public/components/__tests__/__snapshots__/ContentPanel.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`<ContentPanel /> spec renders the component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
Expand Down Expand Up @@ -48,7 +48,7 @@ exports[`<ContentPanel /> spec renders the component 1`] = `

exports[`<ContentPanel /> spec renders with empty actions 1`] = `
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
Expand Down
8 changes: 4 additions & 4 deletions ...-notifications/public/pages/Channels/__tests__/__snapshots__/ChannelActions.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`<ChannelActions/> spec clicks in the popover 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -56,7 +56,7 @@ exports[`<ChannelActions/> spec renders the action button disabled by default 1`
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -91,7 +91,7 @@ exports[`<ChannelActions/> spec renders the popover 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -131,7 +131,7 @@ exports[`<ChannelActions/> spec renders the popover with multiple selected chann
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down
6 changes: 3 additions & 3 deletions ...notifications/public/pages/Channels/__tests__/__snapshots__/ChannelControls.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`<ChannelControls /> spec renders the component 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
class="euiFieldSearch euiFieldSearch--fullWidth euiFieldSearch-isClearable"
class="euiFieldSearch euiFieldSearch--fullWidth"
placeholder="Search"
type="search"
/>
Expand Down Expand Up @@ -60,7 +60,7 @@ exports[`<ChannelControls /> spec renders the component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -98,7 +98,7 @@ exports[`<ChannelControls /> spec renders the component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down
8 changes: 4 additions & 4 deletions ...-notifications/public/pages/Channels/__tests__/__snapshots__/ChannelDetails.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ exports[`<ChannelDetails/> spec handles a non-existing channel 1`] = `
class="euiSpacer euiSpacer--l"
/>
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
style="max-width: 1300px;"
>
<div
Expand Down Expand Up @@ -144,7 +144,7 @@ exports[`<ChannelDetails/> spec handles a non-existing channel 1`] = `
class="euiSpacer euiSpacer--l"
/>
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
style="max-width: 1300px;"
>
<div
Expand Down Expand Up @@ -217,7 +217,7 @@ exports[`<ChannelDetails/> spec renders a specific channel 1`] = `
class="euiSpacer euiSpacer--l"
/>
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
style="max-width: 1300px;"
>
<div
Expand Down Expand Up @@ -315,7 +315,7 @@ exports[`<ChannelDetails/> spec renders a specific channel 1`] = `
class="euiSpacer euiSpacer--l"
/>
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
style="max-width: 1300px;"
>
<div
Expand Down
6 changes: 3 additions & 3 deletions ...cations/public/pages/Channels/__tests__/__snapshots__/ChannelDetailsActions.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ exports[`<ChannelDetailsActions /> spec clicks buttons in popover 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -56,7 +56,7 @@ exports[`<ChannelDetailsActions /> spec opens popover 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -96,7 +96,7 @@ exports[`<ChannelDetailsActions /> spec renders the component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down
48 changes: 12 additions & 36 deletions ...boards-notifications/public/pages/Channels/__tests__/__snapshots__/Channels.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`<Channels/> spec renders the empty component 1`] = `
<div
class="euiPanel euiPanel--paddingMedium"
class="euiPanel euiPanel--paddingMedium euiPanel--borderRadiusMedium euiPanel--plain euiPanel--hasShadow"
>
<div
class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--alignItemsCenter euiFlexGroup--justifyContentSpaceBetween euiFlexGroup--directionRow euiFlexGroup--responsive"
Expand Down Expand Up @@ -53,7 +53,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -114,7 +114,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
class="euiFormControlLayout__childrenWrapper"
>
<input
class="euiFieldSearch euiFieldSearch--fullWidth euiFieldSearch-isClearable"
class="euiFieldSearch euiFieldSearch--fullWidth"
placeholder="Search"
type="search"
/>
Expand Down Expand Up @@ -160,7 +160,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -198,7 +198,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -282,7 +282,7 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoading euiButtonContent__icon"
class="euiIcon euiIcon--small euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height="16"
role="img"
Expand Down Expand Up @@ -355,13 +355,12 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
<span
class="euiTableCellContent__text"
title="Name; Sorted in ascending order"
title="Name"
>
Name
</span>
<svg
aria-hidden="true"
aria-label="Sorted in ascending order"
class="euiIcon euiIcon--medium euiIcon-isLoading euiTableSortIcon"
focusable="false"
height="16"
Expand All @@ -370,11 +369,6 @@ exports[`<Channels/> spec renders the empty component 1`] = `
width="16"
xmlns="http://www.w3.org/2000/svg"
/>
<span
class="euiScreenReaderOnly"
>
Click to sort in descending order
</span>
</span>
</button>
</th>
Expand All @@ -400,11 +394,6 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
Notification status
</span>
<span
class="euiScreenReaderOnly"
>
Click to sort in ascending order
</span>
</span>
</button>
</th>
Expand All @@ -430,11 +419,6 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
Type
</span>
<span
class="euiScreenReaderOnly"
>
Click to sort in ascending order
</span>
</span>
</button>
</th>
Expand All @@ -460,11 +444,6 @@ exports[`<Channels/> spec renders the empty component 1`] = `
>
Description
</span>
<span
class="euiScreenReaderOnly"
>
Click to sort in ascending order
</span>
</span>
</button>
</th>
Expand All @@ -487,14 +466,14 @@ exports[`<Channels/> spec renders the empty component 1`] = `
<div
class="euiEmptyPrompt"
>
<h2
class="euiTitle euiTitle--medium"
>
No channels to display
</h2>
<span
class="euiTextColor euiTextColor--subdued"
>
<h2
class="euiTitle euiTitle--medium"
>
No channels to display
</h2>
<div
class="euiSpacer euiSpacer--m"
/>
Expand All @@ -507,9 +486,6 @@ exports[`<Channels/> spec renders the empty component 1`] = `
<div
class="euiSpacer euiSpacer--l"
/>
<div
class="euiSpacer euiSpacer--s"
/>
<a
class="euiButton euiButton--primary"
href="#/create-channel"
Expand Down
Loading