Fix Notification Dashboards build issues#399
Merged
qreshi merged 3 commits intoopensearch-project:mainfrom Apr 8, 2022
Merged
Conversation
Contributor
Author
|
Need to merge in #395 and rebase with it to get the backend build passing. |
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Signed-off-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
qreshi
force-pushed
the
fix-notif-dashboards
branch
from
0bfb14b to
67d49eb
Compare
dbbaughe
approved these changes
Apr 8, 2022
praveensameneni
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Recent commits to the OpenSearch Dashboards repo caused the bootstrapping of Notifications Dashboards to start failing. This PR makes the following changes to get the build passing again:
enzyme-adapter-react-16version to1.15.5, cypress to6.0.0and updates the yarn.lock fileIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.