Skip to content

fix bwc bug when incrementing to OS 2.6.0#705

Merged
b4sjoo merged 2 commits intoopensearch-project:2.xfrom
b4sjoo:2.x_bwcdev
Jan 24, 2023
Merged

fix bwc bug when incrementing to OS 2.6.0#705
b4sjoo merged 2 commits intoopensearch-project:2.xfrom
b4sjoo:2.x_bwcdev

Conversation

@b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Jan 23, 2023

Signed-off-by: Sicheng Song sicheng.song@outlook.com

Description

Description
This PR will fix the bwc test failure when incrementing to version 2.6.0.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo requested a review from a team January 23, 2023 23:31
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #705 (fb4a6f3) into 2.x (6ae9257) will decrease coverage by 0.59%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #705      +/-   ##
============================================
- Coverage     83.97%   83.38%   -0.59%     
+ Complexity     1033     1019      -14     
============================================
  Files            99       99              
  Lines          3738     3738              
  Branches        344      344              
============================================
- Hits           3139     3117      -22     
- Misses          453      473      +20     
- Partials        146      148       +2     
Flag Coverage Δ
ml-commons 83.38% <ø> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cluster/MLCommonsClusterManagerEventListener.java 65.62% <0.00%> (-12.50%) ⬇️
...org/opensearch/ml/cluster/DiscoveryNodeHelper.java 89.39% <0.00%> (-9.10%) ⬇️
...n/java/org/opensearch/ml/cluster/MLSyncUpCron.java 87.50% <0.00%> (-6.25%) ⬇️
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 85.71% <0.00%> (-4.09%) ⬇️
...ain/java/org/opensearch/ml/task/MLTaskManager.java 59.39% <0.00%> (-2.54%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo merged commit 8561285 into opensearch-project:2.x Jan 24, 2023
@b4sjoo b4sjoo deleted the 2.x_bwcdev branch January 24, 2023 09:50
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2023
b4sjoo added a commit to b4sjoo/ml-commons that referenced this pull request Jan 24, 2023
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
b4sjoo added a commit that referenced this pull request Jan 24, 2023
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@ylwu-amzn ylwu-amzn added the test label Jan 31, 2023
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Feb 17, 2023
ylwu-amzn pushed a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants