Skip to content

Conversation

@b4sjoo
Copy link
Collaborator

@b4sjoo b4sjoo commented Jan 17, 2023

Signed-off-by: Sicheng Song sicheng.song@outlook.com

Description

This PR will fix the bwc test failure when incrementing to version 2.6.0.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo requested review from a team and ylwu-amzn January 17, 2023 22:22
@ylwu-amzn
Copy link
Collaborator

Change "plugins.ml_commons.only_run_on_ml_node" to false in BWC test?

org.opensearch.ml.bwc.MLCommonsBackwardsCompatibilityIT > testBackwardsCompatibility FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://[::1]:42291], URI [/_plugins/_ml/_train_predict/kmeans], status line [HTTP/1.1 500 Internal Server Error]
    {"error":{"root_cause":[{"type":"m_l_resource_not_found_exception","reason":"no eligible node found, ml node is required to run this request"}],"type":"m_l_resource_not_found_exception","reason":"no eligible node found, ml node is required to run this request"},"status":500}

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #698 (741a1e6) into 2.x (83a7d4f) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #698      +/-   ##
============================================
- Coverage     83.49%   83.38%   -0.11%     
+ Complexity     1021     1019       -2     
============================================
  Files            99       99              
  Lines          3738     3738              
  Branches        344      344              
============================================
- Hits           3121     3117       -4     
- Misses          470      473       +3     
- Partials        147      148       +1     
Flag Coverage Δ
ml-commons 83.38% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cluster/MLCommonsClusterManagerEventListener.java 65.62% <0.00%> (-12.50%) ⬇️
.../java/org/opensearch/ml/task/MLTaskDispatcher.java 32.94% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

b4sjoo added 15 commits January 17, 2023 22:44
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
Signed-off-by: Sicheng Song <sicheng.song@outlook.com>
@b4sjoo b4sjoo closed this Jan 23, 2023
@b4sjoo
Copy link
Collaborator Author

b4sjoo commented Jan 23, 2023

This PR is closed because we opened PR #705 for a cleaner look.

@b4sjoo b4sjoo deleted the 2.x_bwcfix branch January 24, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants