Skip to content

Staging for version increment automation #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ylwu-amzn merged 2 commits into from
Jul 26, 2022
Merged

Staging for version increment automation #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d5a00e
Version increment automation
prudhvigodithi Jul 10, 2022
4faa65f
Version increment automation: task rename updateVersion
prudhvigodithi Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,3 +69,20 @@ ext {
dependencies {
implementation 'junit:junit:4.12'
}

// updateVersion: Task to auto increment to the next development iteration
task updateVersion {
onlyIf { System.getProperty('newVersion') }

@ylwu-amzn ylwu-amzn Jul 12, 2022

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this newVersion will be set ? Where and when will this update version task will be executed?

@prudhvigodithi prudhvigodithi Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ylwu-amzn this task updateVersion task will called using a workflow from the build repo example ./gradlew updateVersion -DnewVersion=2.1.0-SNAPSHOT , this newVersion will be compared against core repo and will update the plugin files to increment the version.

@prudhvigodithi prudhvigodithi Jul 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example PR: https://github.com/prudhvigodithi/ml-commons/pull/2/files

doLast {
ext.newVersion = System.getProperty('newVersion')
println "Setting version to ${newVersion}."
// String tokenization to support -SNAPSHOT
ant.replaceregexp(match: opensearch_version.tokenize('-')[0], replace: newVersion.tokenize('-')[0], flags:'g', byline:true) {
fileset(dir: projectDir) {
// Include the required files that needs to be updated with new Version
include(name: "build.gradle")
include(name: ".github/workflows/CI-workflow.yml")
}
}
}
}