Skip to content

Staging for version increment automation#363

Merged
ylwu-amzn merged 2 commits intoopensearch-project:1.xfrom
prudhvigodithi:1.x
Jul 26, 2022
Merged

Staging for version increment automation#363
ylwu-amzn merged 2 commits intoopensearch-project:1.xfrom
prudhvigodithi:1.x

Conversation

@prudhvigodithi
Copy link
Copy Markdown
Member

@prudhvigodithi prudhvigodithi commented Jul 10, 2022

Signed-off-by: pgodithi pgodithi@amazon.com

Description

This is the staging PR for to execute workflows that auto raise the version increment PR's
Example: prudhvigodithi#2

Issues Resolved

Part of: opensearch-project/opensearch-build#1375
From solution: opensearch-project/opensearch-build#1375 (comment)
Related issue: #357

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
@prudhvigodithi prudhvigodithi requested a review from dblock July 12, 2022 22:52
@prudhvigodithi
Copy link
Copy Markdown
Member Author

Renaming to task updateVersion following opensearch-project/opensearch-plugin-template-java#32.


// updateVersion: Task to auto increment to the next development iteration
task updateVersion {
onlyIf { System.getProperty('newVersion') }
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where this newVersion will be set ? Where and when will this update version task will be executed?

Copy link
Copy Markdown
Member Author

@prudhvigodithi prudhvigodithi Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ylwu-amzn this task updateVersion task will called using a workflow from the build repo example ./gradlew updateVersion -DnewVersion=2.1.0-SNAPSHOT , this newVersion will be compared against core repo and will update the plugin files to increment the version.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just ask some question to learn more detail.

@prudhvigodithi
Copy link
Copy Markdown
Member Author

Hey @ylwu-amzn just checking back, if we are ok with PR, can we merge this?
Thank you

@ylwu-amzn ylwu-amzn merged commit ef9763d into opensearch-project:1.x Jul 26, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2022
* Version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>

* Version increment automation: task rename updateVersion

Signed-off-by: pgodithi <pgodithi@amazon.com>
(cherry picked from commit ef9763d)
@ylwu-amzn
Copy link
Copy Markdown
Collaborator

Hey @ylwu-amzn just checking back, if we are ok with PR, can we merge this? Thank you

Sure, merged. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants