Clean up CI script files #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI will fail since license check is not disabled yet. |
jmazanec15
reviewed
Jun 16, 2021
|
|
||
| - name: Build and pull docker files | ||
| env: | ||
| OPENDISTRO_VERSION: "1.13.2" |
There was a problem hiding this comment.
Yeah. This plugin will support elasticsearach oss + opendistro + OpenSearch
There was a problem hiding this comment.
May be we should also add one for pulling opensearch rc1 artifacts for running tests?
There was a problem hiding this comment.
Yeah. This will be part of OpenSearch support
scripts/Dockerfile
Outdated
| ARG DISTRIBUTION | ||
| ENV DISTRIBUTION=$DISTRIBUTION | ||
| # INTEGRATION="true" while integration testing (false-y by default) | ||
| ENV ELASTICSEARCH_OSS_VERSION=$ELASTICSEARCH_OSS_VERSION |
There was a problem hiding this comment.
WHy are we still using Elasticsearch OSS?
jmazanec15
approved these changes
Jun 16, 2021
Keep relevant files to test logstash. Use opendistro instead of Elasticsearch. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Include files like github templates, code of conduct, maintainers, admins, etc. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Enable unit test and integration test on push any branch and any pull request. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
dblock
approved these changes
Jun 21, 2021
|
This is merged as #11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up CI scripts. Add basic opensearch repo template files.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.