Remove non OSS features and tests that checks any ES clusters != 7.X #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep relevant files to test logstash. Use opendistro instead of Elasticsearch. Signed-off-by: Vijayan Balasubramanian <[email protected]>
1 task
|
CI from my fork is succeeded: https://github.com/VijayanB/logstash-output-opensearch/actions/runs/948070327 |
Include files like github templates, code of conduct, maintainers, admins, etc. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Enable unit test and integration test on push any branch and any pull request. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Signed-off-by: Vijayan Balasubramanian <[email protected]>
Remove xpack test and features since this will not be available in OpenSearch. Signed-off-by: Vijayan Balasubramanian <[email protected]>
OpenSearch and opensource should not have license checker. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Groovy is supported upto 6.0 versions. Since we only support opensource 7.X and OpenSearch. We don't need to test groovy scripts. Signed-off-by: Vijayan Balasubramanian <[email protected]>
Since we will be supporting only 7.x and OpenSearch >= 1.x remove tests that are not relevant. Also remove auth support for cloud id. Signed-off-by: Vijayan Balasubramanian <[email protected]>
jmazanec15
reviewed
Jun 17, 2021
| @@ -1,116 +1,7 @@ | |||
| module LogStash; module Outputs; class ElasticSearch | |||
| module Ilm | |||
|
|
|||
There was a problem hiding this comment.
Cant this file be removed? I thought ilm is xpack
spec/fixtures/_nodes/7x.json
Outdated
| "master" | ||
| ], | ||
| "attributes" : { | ||
| "ml.machine_memory" : "17179869184", |
There was a problem hiding this comment.
Cant we remove all ml related code as its xpack?
|
|
||
| subject.register | ||
| subject.multi_receive(event_count.times.map { LogStash::Event.new("link_to" => parent_id, "message" => "Hello World!", join_field => child_relation) }) | ||
| if ESHelper.es_version_satisfies?('<6') |
Signed-off-by: Vijayan Balasubramanian <[email protected]>
|
Can we remove?
|
Signed-off-by: Vijayan Balasubramanian <[email protected]>
|
jmazanec15
approved these changes
Jun 21, 2021
VijayanB
added
the
Refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove multiple versions
Remove groovy scripts
Remove license checker
clean up data stream
Delete xpack files
Update ADMINS
Remove iml files
Set github workflow
Use opensearch basic template
Clean up build and test files
Issues Resolved
#10
#3
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.