Skip to content

Replace commons-lang with org.apache.commons:commons-lang3 #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2025
Merged

Replace commons-lang with org.apache.commons:commons-lang3 #2863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1be710
Replace commons-lang with org.apache.commons:commons-lang3
markwu-sde Sep 3, 2025
637dcc6
Changelog update
markwu-sde Sep 3, 2025
bbaacdf
Change slf4j to use version library in core
markwu-sde Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ All notable changes to this project are documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). See the [CONTRIBUTING guide](./CONTRIBUTING.md#Changelog) for instructions on how to add changelog entries.

## [Unreleased 3.3](https://github.com/opensearch-project/k-NN/compare/main...HEAD)
### Maintenance
* Replace commons-lang with org.apache.commons:commons-lang3 [#2863](https://github.com/opensearch-project/k-NN/pull/2863)
### Refactoring
* Refactored the KNN Stat files for better readability.

Expand Down
5 changes: 2 additions & 3 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ dependencies {
compileOnly "org.opensearch:protobufs:0.6.0"
compileOnly group: 'com.google.guava', name: 'failureaccess', version:'1.0.2'
compileOnly group: 'com.google.guava', name: 'guava', version:'33.2.1-jre'
api group: 'commons-lang', name: 'commons-lang', version: '2.6'
api "org.apache.commons:commons-lang3:${versions.commonslang}"
testFixturesImplementation "org.opensearch.test:framework:${opensearch_version}"
// Add Guava for test configurations since it's needed for testing but excluded from runtime
testImplementation group: 'com.google.guava', name: 'guava', version:'33.2.1-jre'
Expand All @@ -369,8 +369,7 @@ dependencies {
implementation 'com.github.oshi:oshi-core:6.4.13'
api "net.java.dev.jna:jna:${versions.jna}"
api "net.java.dev.jna:jna-platform:${versions.jna}"
// OpenSearch core is using slf4j 1.7.36. Therefore, we cannot change the version here.
implementation 'org.slf4j:slf4j-api:1.7.36'
implementation "org.slf4j:slf4j-api:${versions.slf4j}"
zipArchive group: 'org.opensearch.plugin', name:'opensearch-security', version: "${opensearch_build}"
}

Expand Down
Loading