Replace commons-lang with org.apache.commons:commons-lang3 #2863
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Wu <[email protected]>
Signed-off-by: Mark Wu <[email protected]>
markwu-sde
force-pushed
the
CVE-2025-48924
branch
from
feda531 to
637dcc6
Compare
Signed-off-by: Mark Wu <[email protected]>
markwu-sde
requested review from
0ctopus13prime,
VijayanB,
Vikasht34,
heemin32,
jmazanec15,
junqiu-lei,
luyuncheng,
martin-gaievski,
naveentatikonda,
navneet1v,
ryanbogan,
shatejas and
vamshin
as code owners
0ctopus13prime
approved these changes
Sep 3, 2025
shatejas
approved these changes
Sep 3, 2025
0ctopus13prime
merged commit 61f0d18
into
opensearch-project:main
58 of 59 checks passed
Member
|
Hey @markwu-sde this broke other plugins that depend on both neural-search and knn: I think this dependency needs to be |
Contributor
Author
|
Yeah - previously we were using the legacy common lang package and so we weren't running into compile issues since I think neural plugin already moved over to common-lang3 a while ago. I'll send out another PR for this. |
Member
|
No worries and no great rush. Might want to look at your other api dependencies while you're at it. :) |
Member
|
@markwu-sde neural plugin is also failing with jar hell |
Contributor
Author
|
@owaiskazi19 can we have the neural-plugin reference the version catalog library instead? I'm not sure exactly why we're extending the common-lang library so will need to do a little more digging on that |
5 tasks
5 tasks
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.19 2.19
# Navigate to the new working tree
cd .worktrees/backport-2.19
# Create a new branch
git switch --create backport/backport-2863-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 61f0d18401fdb2d3a018a1c13ef8c867e2e60b97
# Push it to GitHub
git push --set-upstream origin backport/backport-2863-to-2.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.19Then, create a pull request where the |
Member
|
Hi folks, |
Collaborator
|
@VijayanB please check this |
Member
|
@navneet1v @gaiksaya Will do manual backport and update here |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make build.gradle use the version library for commons-lang3 and slf4j. This should fix the vulnerability CVE-2025-48924 and avoid us having to bump versions to be the same with core.
Related Issues
Resolves CVE-2025-48924
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.