ImmutableOpenMap removal compile fix#766
ImmutableOpenMap removal compile fix#766petardz wants to merge 4 commits intoopensearch-project:mainfrom
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #766 +/- ##
============================================
- Coverage 75.58% 75.35% -0.24%
+ Complexity 2680 2661 -19
============================================
Files 337 337
Lines 15562 15562
Branches 2286 2286
============================================
- Hits 11763 11727 -36
- Misses 2462 2492 +30
- Partials 1337 1343 +6
|
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip |
There was a problem hiding this comment.
There is another PR opensearch-project/notifications#663 to bump the gradle version to 8.1.1
There was a problem hiding this comment.
8.1.1 didn't work for me. I got licence file issues and few more
There was a problem hiding this comment.
Ah nevermind.. something changed again in meanwhile. 7.6.1 is not working anymore
|
Hi, DCO shows that the sign-off is missing in two of your commits. Please follow the instructions to add your sign-off, thanks! |
|
It is good to see you making new commits, but you need to add sign-off to each of your commit. For more details, you can refer to instructions listed in DCO tests. |
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
|
Great, your commit has passed the DCO test! I am here to notifying you of some recent changes on the the main repository. A pull request has just been approved, which includes some fixes with ImmutableOpenMap removal issue. I assume there is some overlapping with your code changes. Also, the conflicts need to be resolved. You can take a look at the latest commit for detailed information. |
oops.. fixed it! yea I saw @bowenlan-amzn PR |
|
Probably no need for this ImmutableOpenMap change. Can proceed to work on the bug fix. Thanks! |
Issue #, if available:
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.