Skip to content

ImmutableOpenMap removal compile fix#766

Closed
petardz wants to merge 4 commits intoopensearch-project:mainfrom
petardz:compile-fox
Closed

ImmutableOpenMap removal compile fix#766
petardz wants to merge 4 commits intoopensearch-project:mainfrom
petardz:compile-fox

Conversation

@petardz
Copy link
Copy Markdown
Contributor

@petardz petardz commented May 1, 2023

Issue #, if available:

Description of changes:

CheckList:

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@petardz petardz requested a review from a team May 1, 2023 16:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 1, 2023

Codecov Report

Merging #766 (fdaa2d8) into main (19fc44b) will decrease coverage by 0.24%.
The diff coverage is 62.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #766      +/-   ##
============================================
- Coverage     75.58%   75.35%   -0.24%     
+ Complexity     2680     2661      -19     
============================================
  Files           337      337              
  Lines         15562    15562              
  Branches       2286     2286              
============================================
- Hits          11763    11727      -36     
- Misses         2462     2492      +30     
- Partials       1337     1343       +6     
Impacted Files Coverage Δ
...ndexstatemanagement/IndexStateManagementHistory.kt 77.24% <0.00%> (ø)
...agement/indexstatemanagement/ManagedIndexRunner.kt 47.13% <0.00%> (-0.45%) ⬇️
.../rollup/util/RollupFieldValueExpressionResolver.kt 61.53% <0.00%> (ø)
...atemanagement/step/shrink/AttemptMoveShardsStep.kt 57.70% <50.00%> (ø)
...atemanagement/step/shrink/WaitForMoveShardsStep.kt 49.23% <75.00%> (ø)
...management/indexstatemanagement/MetadataService.kt 64.92% <100.00%> (ø)
...temanagement/opensearchapi/OpenSearchExtensions.kt 71.60% <100.00%> (ø)
...exstatemanagement/step/shrink/WaitForShrinkStep.kt 42.00% <100.00%> (ø)
...transport/action/explain/TransportExplainAction.kt 70.75% <100.00%> (ø)
...arch/indexmanagement/rollup/RollupMapperService.kt 58.58% <100.00%> (ø)
... and 1 more

... and 17 files with indirect coverage changes

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another PR opensearch-project/notifications#663 to bump the gradle version to 8.1.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.1.1 didn't work for me. I got licence file issues and few more

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind.. something changed again in meanwhile. 7.6.1 is not working anymore

@yuye-aws
Copy link
Copy Markdown
Member

yuye-aws commented May 5, 2023

Hi, DCO shows that the sign-off is missing in two of your commits. Please follow the instructions to add your sign-off, thanks!

@yuye-aws
Copy link
Copy Markdown
Member

yuye-aws commented May 8, 2023

It is good to see you making new commits, but you need to add sign-off to each of your commit. For more details, you can refer to instructions listed in DCO tests.

petardz added 4 commits May 8, 2023 16:13
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
Signed-off-by: Petar Dzepina <petar.dzepina@gmail.com>
@yuye-aws
Copy link
Copy Markdown
Member

yuye-aws commented May 9, 2023

Great, your commit has passed the DCO test! I am here to notifying you of some recent changes on the the main repository. A pull request has just been approved, which includes some fixes with ImmutableOpenMap removal issue. I assume there is some overlapping with your code changes. Also, the conflicts need to be resolved. You can take a look at the latest commit for detailed information.

@petardz
Copy link
Copy Markdown
Contributor Author

petardz commented May 9, 2023

It is good to see you making new commits, but you need to add sign-off to each of your commit. For more details, you can refer to instructions listed in DCO tests.

oops.. fixed it!

yea I saw @bowenlan-amzn PR

@bowenlan-amzn
Copy link
Copy Markdown
Member

Probably no need for this ImmutableOpenMap change. Can proceed to work on the bug fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants