Skip to content

Fix blank page when trying to list SM policies when one of them does not have creation field #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ztomaszewska wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −9
Open

Fix blank page when trying to list SM policies when one of them does not have creation field #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c52d11
fix sm policy list and details when creation schedule is null
ztomaszewska Mar 17, 2026
bc7dda5
frequencyType not parsed properly
ztomaszewska Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions public/pages/SnapshotPolicies/containers/SnapshotPolicies/SnapshotPolicies.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@ export class SnapshotPolicies extends MDSEnabledComponent<SnapshotPoliciesProps,
dataType: "string",
width: "180px",
render: (name: string, item: SMPolicy) => {
if (!item.creation) {
return "-";
}
const expression = name;
const timezone = item.creation.schedule.cron.timezone;
return `${humanCronExpression(parseCronExpression(expression), expression, timezone)}`;
Expand Down
24 changes: 15 additions & 9 deletions ...ic/pages/SnapshotPolicyDetails/containers/SnapshotPolicyDetails/SnapshotPolicyDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,16 +299,22 @@ export class SnapshotPolicyDetails extends MDSEnabledComponent<SnapshotPolicyDet
// { term: "Time zone of timestamp", value: `${_.get(policy, "snapshot_config.date_format_timezone")}` },
];

const createCronExpression = policy.creation.schedule.cron.expression;
const { minute, hour, dayOfWeek, dayOfMonth, frequencyType } = parseCronExpression(createCronExpression);
const humanCron = humanCronExpression(
{ minute, hour, dayOfWeek, dayOfMonth, frequencyType },
createCronExpression,
policy.creation.schedule.cron.timezone
);
let frequency;
let humanCron;
if (policy.creation != null) {
const createCronExpression = policy.creation.schedule.cron.expression;
const { minute, hour, dayOfWeek, dayOfMonth, frequencyType } = parseCronExpression(createCronExpression);
frequency = _.capitalize(frequencyType);
humanCron = humanCronExpression(
{ minute, hour, dayOfWeek, dayOfMonth, frequencyType },
createCronExpression,
policy.creation.schedule.cron.timezone
);
}

const snapshotScheduleItems = [
{ term: "Frequency", value: _.capitalize(frequencyType) },
{ term: "Cron schedule", value: humanCron },
{ term: "Frequency", value: frequency ?? "-" },
{ term: "Cron schedule", value: humanCron ?? "-" },
{ term: "Next snapshot time", value: renderTimestampMillis(metadata?.creation?.trigger.time) },
];

Expand Down