Fix blank page when trying to list SM policies when one of them does not have creation field#1407
Open
ztomaszewska wants to merge 2 commits into
Open
Conversation
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
Signed-off-by: Zuzanna Tomaszewska <zuzanna.tomaszewska@sap.com>
ztomaszewska
requested review from
Hailong-am,
RamakrishnaChilaka,
SuZhou-Joe,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It's impossible to list Snapshot Policies if one of the policies does not have creation field defined. This opensearch-project/index-management#1452 made the creation field optional in SMPolicy, allowing deletion-only policies.
This PR makes it possible to view policy list even when one of policies does not have creation field.
Issues Resolved
#1405
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.