Conversation
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
…o simplify wording. Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
…icable. Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
natebower
left a comment
There was a problem hiding this comment.
LGTM with one minor change.
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
Signed-off-by: carolxob <carolxob@amazon.com>
* Add Peer forwarder to doc site repo. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates to header section. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading adjustements. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading updates. Additional of Optional section to simplify wording. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading adjustments. Signed-off-by: carolxob <carolxob@amazon.com> * Changed capitalization in title. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Trying to commit file. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file again. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file one more time after rebasing. Signed-off-by: carolxob <carolxob@amazon.com> * Minor change. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits. Signed-off-by: carolxob <carolxob@amazon.com> * Converted optional configuration section to table. Signed-off-by: carolxob <carolxob@amazon.com> * Minor adjustmenets. Signed-off-by: carolxob <carolxob@amazon.com> * Minor adjustments again. Signed-off-by: carolxob <carolxob@amazon.com> * Updates from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made changes based on doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor heading adjustements. Signed-off-by: carolxob <carolxob@amazon.com> * Made edits based on doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made updates based on editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made extensive changes based on editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated minor editorial feedback changes. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated more editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes. Signed-off-by: carolxob <carolxob@amazon.com> * Committed existing Peer Forwarder file to new PR to simplify feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes. Signed-off-by: carolxob <carolxob@amazon.com> * Updates specifically to table formatting. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor edit to the end of the Configuration table. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates from doc review. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated more editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor update to line 112. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor edits to references to S3. Changed to Amazon S3 where applicable. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates to text. Signed-off-by: carolxob <carolxob@amazon.com> * Made updates based on SME and doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor change to one word. Signed-off-by: carolxob <carolxob@amazon.com> * Removed a comma. Signed-off-by: carolxob <carolxob@amazon.com> --------- Signed-off-by: carolxob <carolxob@amazon.com> Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.2 2.2
# Navigate to the new working tree
cd .worktrees/backport-2.2
# Create a new branch
git switch --create backport/backport-2373-to-2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.2Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-2373-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2373-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3Then, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-2373-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1Then, create a pull request where the |
* Add Peer forwarder to doc site repo. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates to header section. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading adjustements. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading updates. Additional of Optional section to simplify wording. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading adjustments. Signed-off-by: carolxob <carolxob@amazon.com> * Changed capitalization in title. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Trying to commit file. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file again. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file one more time after rebasing. Signed-off-by: carolxob <carolxob@amazon.com> * Minor change. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits. Signed-off-by: carolxob <carolxob@amazon.com> * Converted optional configuration section to table. Signed-off-by: carolxob <carolxob@amazon.com> * Minor adjustmenets. Signed-off-by: carolxob <carolxob@amazon.com> * Minor adjustments again. Signed-off-by: carolxob <carolxob@amazon.com> * Updates from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made changes based on doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor heading adjustements. Signed-off-by: carolxob <carolxob@amazon.com> * Made edits based on doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made updates based on editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made extensive changes based on editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated minor editorial feedback changes. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated more editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes. Signed-off-by: carolxob <carolxob@amazon.com> * Committed existing Peer Forwarder file to new PR to simplify feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes. Signed-off-by: carolxob <carolxob@amazon.com> * Updates specifically to table formatting. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor edit to the end of the Configuration table. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates from doc review. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated more editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor update to line 112. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor edits to references to S3. Changed to Amazon S3 where applicable. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates to text. Signed-off-by: carolxob <carolxob@amazon.com> * Made updates based on SME and doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor change to one word. Signed-off-by: carolxob <carolxob@amazon.com> * Removed a comma. Signed-off-by: carolxob <carolxob@amazon.com> --------- Signed-off-by: carolxob <carolxob@amazon.com> Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> (cherry picked from commit 86385d4)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.4 2.4
# Navigate to the new working tree
cd .worktrees/backport-2.4
# Create a new branch
git switch --create backport/backport-2373-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 86385d4932881cfa70637bbebbabc1e98fd18cfe
# Push it to GitHub
git push --set-upstream origin backport/backport-2373-to-2.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.4Then, create a pull request where the |
* Add Peer forwarder to doc site repo. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates to header section. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading adjustements. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading updates. Additional of Optional section to simplify wording. Signed-off-by: carolxob <carolxob@amazon.com> * Minor copyedits and heading adjustments. Signed-off-by: carolxob <carolxob@amazon.com> * Changed capitalization in title. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Update _data-prepper/peer-forwarder.md Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> * Trying to commit file. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file again. Signed-off-by: carolxob <carolxob@amazon.com> * Trying to push file one more time after rebasing. Signed-off-by: carolxob <carolxob@amazon.com> * Minor change. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits. Signed-off-by: carolxob <carolxob@amazon.com> * Converted optional configuration section to table. Signed-off-by: carolxob <carolxob@amazon.com> * Minor adjustmenets. Signed-off-by: carolxob <carolxob@amazon.com> * Minor adjustments again. Signed-off-by: carolxob <carolxob@amazon.com> * Updates from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made changes based on doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor heading adjustements. Signed-off-by: carolxob <carolxob@amazon.com> * Made edits based on doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made updates based on editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Made extensive changes based on editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated minor editorial feedback changes. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated more editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes. Signed-off-by: carolxob <carolxob@amazon.com> * Committed existing Peer Forwarder file to new PR to simplify feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Minor changes. Signed-off-by: carolxob <carolxob@amazon.com> * Updates specifically to table formatting. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor edit to the end of the Configuration table. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits from doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates from doc review. Signed-off-by: carolxob <carolxob@amazon.com> * Incorporated more editorial feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor update to line 112. Signed-off-by: carolxob <carolxob@amazon.com> * Made minor edits to references to S3. Changed to Amazon S3 where applicable. Signed-off-by: carolxob <carolxob@amazon.com> * Minor edits. Signed-off-by: carolxob <carolxob@amazon.com> * Minor updates to text. Signed-off-by: carolxob <carolxob@amazon.com> * Made updates based on SME and doc review feedback. Signed-off-by: carolxob <carolxob@amazon.com> * Minor change to one word. Signed-off-by: carolxob <carolxob@amazon.com> * Removed a comma. Signed-off-by: carolxob <carolxob@amazon.com> --------- Signed-off-by: carolxob <carolxob@amazon.com> Co-authored-by: Aria Marble <111301581+ariamarble@users.noreply.github.com> (cherry picked from commit 86385d4) Co-authored-by: Caroline <113052567+carolxob@users.noreply.github.com>
Description
This PR takes feedback provided in PR #1936 and makes it easier to provide additional feedback.
Issues Resolved
Addresses feedback in #1936
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.