Skip to content

Add Peer forwarder to doc website repo.#1936

Closed
carolxob wants to merge 32 commits intomainfrom
peer-forwarder
Closed

Add Peer forwarder to doc website repo.#1936
carolxob wants to merge 32 commits intomainfrom
peer-forwarder

Conversation

@carolxob
Copy link
Contributor

@carolxob carolxob commented Nov 16, 2022 •
edited
Loading

Signed-off-by: carolxob carolxob@amazon.com

Description

Add Peer forwarder to doc website repo.

Issues Addressed

Addresses #1267

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@carolxob
Add Peer forwarder to doc site repo.
30586d3 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob added In progress Issue/PR: The issue or PR is in progress. data-prepper labels Nov 16, 2022
@carolxob carolxob self-assigned this Nov 16, 2022
@carolxob carolxob mentioned this pull request Nov 16, 2022
Closed
19 tasks
@carolxob
Minor updates.
73fab9f 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor updates to header section.
f8feef6 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob changed the title Add Peer forwarder to doc site repo. Add Peer forwarder to doc website repo. Nov 16, 2022
@carolxob
Minor copyedits and heading adjustements.
24d4a5e 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor copyedits and heading updates. Additional of Optional section t…
7fb9b33 
…o simplify wording.

Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor copyedits and heading adjustments.
e709ce9 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob added Tech review PR: Tech review in progress and removed In progress Issue/PR: The issue or PR is in progress. labels Nov 22, 2022
@carolxob
Copy link
Contributor Author

carolxob commented Nov 22, 2022

@dlvenable This PR is ready for tech review.

@carolxob carolxob marked this pull request as ready for review November 23, 2022 19:39
@carolxob carolxob requested a review from a team as a code owner November 23, 2022 19:39
asifsmohammed
asifsmohammed reviewed Dec 8, 2022
View reviewed changes
@carolxob
Changed capitalization in title.
74d1ed3 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob carolxob added Doc review PR: Doc review in progress and removed Tech review PR: Tech review in progress labels Dec 9, 2022
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
ariamarble
ariamarble reviewed Dec 9, 2022
View reviewed changes
@carolxob
Trying to push file again.
ab8edae 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Trying to push file one more time after rebasing.
f83dffd 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor change.
0ee7850 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor edits.
2cb064d 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Converted optional configuration section to table.
0609ee4 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor adjustmenets.
2d1cf02 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor adjustments again.
cb5134a 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Updates from doc review feedback.
0b4a055 
Signed-off-by: carolxob <carolxob@amazon.com>
vagimeli
vagimeli approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob See my doc review comments. Looks good overall.

@carolxob
Made changes based on doc review feedback.
850625f 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Made minor heading adjustements.
588da3f 
Signed-off-by: carolxob <carolxob@amazon.com>
ariamarble
ariamarble approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changes

@carolxob carolxob added 5 - Final Editorial Review and removed Doc review PR: Doc review in progress labels Dec 13, 2022
@carolxob
Made edits based on doc review feedback.
81e08ed 
Signed-off-by: carolxob <carolxob@amazon.com>
natebower
natebower suggested changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carolxob Please see my comments and changes and let me know if you have any questions. Thanks!

@carolxob
Made updates based on editorial feedback.
9f5313e 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Made extensive changes based on editorial feedback.
156ddc7 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Incorporated minor editorial feedback changes.
5c640ca 
Signed-off-by: carolxob <carolxob@amazon.com>
@Naarcha-AWS Naarcha-AWS added Doc review PR: Doc review in progress and removed 5 - Final Editorial Review labels Dec 27, 2022
@carolxob
Incorporated more editorial feedback.
a0eb2ec 
Signed-off-by: carolxob <carolxob@amazon.com>
@carolxob
Minor changes.
069ef71 
Signed-off-by: carolxob <carolxob@amazon.com>
@Naarcha-AWS Naarcha-AWS requested a review from natebower January 9, 2023 18:35
@carolxob carolxob mentioned this pull request Jan 10, 2023
Merged
1 task
@carolxob
Copy link
Contributor Author

carolxob commented Jan 10, 2023

Closing this PR to avoid confusion/difficulty with feedback provided. Replaced by #2373

@carolxob carolxob closed this Jan 10, 2023
@carolxob carolxob reopened this Jan 10, 2023
@carolxob carolxob closed this Jan 10, 2023
@hdhalter hdhalter deleted the peer-forwarder branch March 28, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@natebower natebower Awaiting requested review from natebower

3 more reviewers

@asifsmohammed asifsmohammed asifsmohammed left review comments

@vagimeli vagimeli vagimeli approved these changes

@ariamarble ariamarble ariamarble approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carolxob carolxob

Labels

data-prepper Doc review PR: Doc review in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@carolxob @ariamarble @asifsmohammed @natebower @vagimeli @Naarcha-AWS