Add a codecov directory fix to the config#1280
Merged
Swiddis merged 3 commits intoopensearch-project:mainfrom Dec 4, 2023
Merged
Add a codecov directory fix to the config#1280Swiddis merged 3 commits intoopensearch-project:mainfrom
Swiddis merged 3 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
YANG-DB,
anirudha,
dai-chen,
derek-ho,
joshuali925,
kavithacm,
mengweieric,
paulstn,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az,
sumukhswamy and
vamsimanohar
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
=======================================
Coverage 56.32% 56.32%
=======================================
Files 327 327
Lines 11944 11944
Branches 2741 2741
=======================================
Hits 6728 6728
Misses 5171 5171
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YANG-DB
approved these changes
Dec 1, 2023
sumukhswamy
approved these changes
Dec 4, 2023
RyanL1997
added a commit
to RyanL1997/dashboards-observability
that referenced
this pull request
Apr 18, 2024
opensearch-project#1277) (opensearch-project#1280) * Fix tenant label for custom tenant when both Global and Private tenants are disabled Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 1cffd90d8fc54d95edf338bc40a89eecfc3795b7) Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In my continuing campaign of being minorly inconvenienced by our codecov badge, I also noticed that because codecov isn't correctly handling the relative directory of the test runner, it's not producing results with line-by-line coverage. This PR is another one-liner fix that activates the feature by adding a path fix.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.