Skip to content

Registering an expression function to retrieve anomalies#447

Closed
amitgalitz wants to merge 17 commits intoopensearch-project:featureAnywherefrom
amitgalitz:expression-fn
Closed

Registering an expression function to retrieve anomalies#447
amitgalitz wants to merge 17 commits intoopensearch-project:featureAnywherefrom
amitgalitz:expression-fn

Conversation

@amitgalitz
Copy link
Copy Markdown
Member

Description

Creates and registers an expression function to retrieve anomalies from AD as a vis-layer to be rendered on top of visualizations in OSD.

The expression function takes a detectorId argument and utilizes the date range in the context to fetch anomalies. The anomalies are then returned as vis-layer which visualize_embeddable in OSD renders onto the given visualization.

This PR is rebased on this associated detector flyout PR (#442) as it required some of the base functionality for testing. This can either be merged after that PR is finalized or this one can be refactored to be only rebased from the featureAnywhere branch.

Issues Resolved

#408

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

jackiehanyang and others added 17 commits March 28, 2023 22:28
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@amitgalitz amitgalitz requested review from a team, jackiehanyang and ohltyler March 29, 2023 05:36
@amitgalitz
Copy link
Copy Markdown
Member Author

@ohltyler In terms of making review easier the last commit 0722825 is the one that has all the custom expression function logic. I will add tests today/tomorrow

@ohltyler
Copy link
Copy Markdown
Member

@ohltyler In terms of making review easier the last commit 0722825 is the one that has all the custom expression function logic. I will add tests today/tomorrow

Could you create a clean branch that just includes these changes? That way it can be reviewed and merged separately and any review context won't be lost when this would inevitably have to be rebased

@ohltyler ohltyler mentioned this pull request Mar 29, 2023
1 task
@amitgalitz amitgalitz closed this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants