Associated detectors flyout#442
Closed
amitgalitz wants to merge 16 commits intoopensearch-project:featureAnywherefrom
Closed
Associated detectors flyout#442amitgalitz wants to merge 16 commits intoopensearch-project:featureAnywherefrom
amitgalitz wants to merge 16 commits intoopensearch-project:featureAnywherefrom
Conversation
b0e4387 to
e753656
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## featureAnywhere #442 +/- ##
===================================================
- Coverage 51.97% 50.72% -1.26%
===================================================
Files 149 157 +8
Lines 5031 5189 +158
Branches 968 989 +21
===================================================
+ Hits 2615 2632 +17
- Misses 2157 2298 +141
Partials 259 259 see 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
e753656 to
eaa3300
Compare
1 task
Member
|
Same comment as #447 (comment) If you can include a branch with the isolated changes that will speed up and make the review clean. |
Member
|
Closing in favor of #449 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds the associated detectors flyout as part of the feature-anywhere project. This flyout allows you to view all the detectors associated with a particular visualization. From the flyout a user can unlink a detector from a visualization or search up their associated detectors and click on it to view the detector details on the AD plugin.
This PR also includes code from an unmerged PRs. All my specific changes are starting from commit: 60d63ec
Additionally in this PR the "Associate Detector" button doesn't do anything, the reason for this is that it relies on some other changes in the CreateAnomalyDetector flyout that aren't merged yet. I will add this functionality on another PR.
Screenshot of flyout
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.