Skip to content

Associated detectors flyout#442

Closed
amitgalitz wants to merge 16 commits intoopensearch-project:featureAnywherefrom
amitgalitz:ad-anywhere-2
Closed

Associated detectors flyout#442
amitgalitz wants to merge 16 commits intoopensearch-project:featureAnywherefrom
amitgalitz:ad-anywhere-2

Conversation

@amitgalitz
Copy link
Copy Markdown
Member

@amitgalitz amitgalitz commented Mar 20, 2023

Description

This change adds the associated detectors flyout as part of the feature-anywhere project. This flyout allows you to view all the detectors associated with a particular visualization. From the flyout a user can unlink a detector from a visualization or search up their associated detectors and click on it to view the detector details on the AD plugin.

This PR also includes code from an unmerged PRs. All my specific changes are starting from commit: 60d63ec

Additionally in this PR the "Associate Detector" button doesn't do anything, the reason for this is that it relies on some other changes in the CreateAnomalyDetector flyout that aren't merged yet. I will add this functionality on another PR.

Screenshot of flyout

Screenshot 2023-03-27 at 10 00 21 AM

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz force-pushed the ad-anywhere-2 branch 4 times, most recently from b0e4387 to e753656 Compare March 27, 2023 17:18
@amitgalitz amitgalitz marked this pull request as ready for review March 27, 2023 17:20
@amitgalitz amitgalitz requested review from a team, jackiehanyang and ohltyler March 27, 2023 17:20
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #442 (e753656) into featureAnywhere (553cbdd) will decrease coverage by 1.26%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                 Coverage Diff                 @@
##           featureAnywhere     #442      +/-   ##
===================================================
- Coverage            51.97%   50.72%   -1.26%     
===================================================
  Files                  149      157       +8     
  Lines                 5031     5189     +158     
  Branches               968      989      +21     
===================================================
+ Hits                  2615     2632      +17     
- Misses                2157     2298     +141     
  Partials               259      259              

see 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jackiehanyang and others added 16 commits March 28, 2023 22:28
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Jackie Han <jkhanjob@gmail.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@ohltyler
Copy link
Copy Markdown
Member

Same comment as #447 (comment)

If you can include a branch with the isolated changes that will speed up and make the review clean.

@amitgalitz amitgalitz marked this pull request as draft March 31, 2023 00:22
@ohltyler
Copy link
Copy Markdown
Member

Closing in favor of #449

@ohltyler ohltyler closed this May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants