-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[Remote Segment Store] Use files from segmentInfosSnapshot in upload #8487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Segment Store] Use files from segmentInfosSnapshot in upload #8487
Conversation
Gradle Check (Jenkins) Run Completed with:
|
3fd4d8b to
45b2571
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
Taking a look at test failures in |
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForcemergeIT.java
Outdated
Show resolved
Hide resolved
|
New integ tests are executed 180+ times on local to avoid checking in flaky tests. |
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Outdated
Show resolved
Hide resolved
ashking94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
b8c3aa8 to
3590576
Compare
Gradle Check (Jenkins) Run Completed with:
|
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/opensearch/remotestore/RemoteStoreForceMergeIT.java
Outdated
Show resolved
Hide resolved
3590576 to
cec103f
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
Signed-off-by: Sachin Kale <[email protected]>
cec103f to
373976d
Compare
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-8487-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 230a06daee9c8484e38d6aad867a98c3c10c2485
# Push it to GitHub
git push --set-upstream origin backport/backport-8487-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…8487) (#8772) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]>
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…pensearch-project#8487) * Use files from segmentInfosSnapshot in upload --------- Signed-off-by: Sachin Kale <[email protected]> Co-authored-by: Sachin Kale <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
RemoteStoreRefreshListeneris one of the refresh listeners that uploads segments to remote segment store.segmentInfosSnapshotfrom InternalEngine and adds files referenced bysegments_Nfile.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.