Skip to content

Conversation

@ryanbogan
Copy link
Member

Description

In order to run integration testing for the SDK and future extensions, the OpenSearch gradle plugin needs to be able to run both extensions and plugins at the same time. This PR adds the capability to run extensions from the gradle plugin, while leaving all existing plugin functionality untouched.

Backport of #7235

Issues Resolved

opensearch-project/opensearch-sdk-java#589

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@ryanbogan ryanbogan changed the title Add extensions to gradle plugin [Backport 2.x] Add extensions to gradle plugin May 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.indices.replication.SegmentReplicationIT.testScrollWithOngoingSegmentReplication

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #7430 (8707b17) into 2.x (5e5d7ee) will increase coverage by 0.54%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x    #7430      +/-   ##
============================================
+ Coverage     70.34%   70.88%   +0.54%     
- Complexity    59728    60209     +481     
============================================
  Files          4863     4865       +2     
  Lines        287390   287453      +63     
  Branches      41749    41753       +4     
============================================
+ Hits         202161   203775    +1614     
+ Misses        68230    67000    -1230     
+ Partials      16999    16678     -321     
Impacted Files Coverage Δ
...arch/gradle/testclusters/ExtensionsProperties.java 0.00% <0.00%> (ø)
...nsearch/gradle/testclusters/OpenSearchCluster.java 0.00% <0.00%> (ø)
...opensearch/gradle/testclusters/OpenSearchNode.java 0.00% <0.00%> (ø)
.../gradle/testclusters/TestClusterConfiguration.java 0.00% <ø> (ø)
...search/gradle/testclusters/TestExtensionsList.java 0.00% <0.00%> (ø)

... and 524 files with indirect coverage changes

@ryanbogan ryanbogan merged commit 81d1778 into 2.x May 8, 2023
@ryanbogan ryanbogan deleted the backport/backport-7235-to-2.x branch May 8, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants