-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add extensions to gradle plugin #7235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extensions to gradle plugin #7235
Conversation
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ryan Bogan <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
buildSrc/src/main/java/org/opensearch/gradle/testclusters/ExtensionsProperties.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/TestExtensionsList.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Ryan Bogan <[email protected]>
|
This doesn't only affect extensions, so should I add a changelog entry? |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
dblock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looking at this code, I am wondering whether we should extract the connectivity parts of an extension into an interface? I suspect that for in-proc we will not want host/port as a communication channel. WDYT?
|
@owaiskazi19 Ryan addressed the comments, could you take a look again? |
Makes sense. Definitely they have to be APIs. And abstract out inner structures. We started with something very simple, its about time to build these changes. |
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/opensearch/gradle/testclusters/OpenSearchNode.java
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <[email protected]>
Gradle Check (Jenkins) Run Completed with:
|
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7235-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 84d66e091a3dc4c52f72f64b3bbd2d45580feb48
# Push it to GitHub
git push --set-upstream origin backport/backport-7235-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
* Add extension functionality to OpenSearch gradle plugin Signed-off-by: Ryan Bogan <[email protected]> * Modify gradle plugin to run both extensions and plugins Signed-off-by: Ryan Bogan <[email protected]> * Fix spotless Signed-off-by: Ryan Bogan <[email protected]> * Change feature flag initialization Signed-off-by: Ryan Bogan <[email protected]> * Address PR comments Signed-off-by: Ryan Bogan <[email protected]> * Change error method and remove unnecessary feature flag setting Signed-off-by: Ryan Bogan <[email protected]> --------- Signed-off-by: Ryan Bogan <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
In order to run integration testing for the SDK and future extensions, the OpenSearch gradle plugin needs to be able to run both extensions and plugins at the same time. This PR adds the capability to run extensions from the gradle plugin, while leaving all existing plugin functionality untouched.
Issues Resolved
opensearch-project/opensearch-sdk-java#589
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.