Fixes precommit task configuration failures due to newly added missin… #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2021 14:47
…gJavadoc task Signed-off-by: Himanshu Setia <[email protected]>
Signed-off-by: Himanshu Setia <[email protected]>
|
start gradle check |
|
✅ Gradle Wrapper Validation success 90cbbd4 |
|
✅ DCO Check Passed 90cbbd4 |
5 tasks
|
✅ Gradle Precommit success 90cbbd4 |
|
If I can get an approval here, I will merge this and raise another PR for merging the javadoc feature branch into main. This will help in channeling all incoming new javadoc contributions directly into main branch. |
This was referenced May 17, 2021
setiah
added a commit
that referenced
this pull request
May 18, 2021
* Adds a gradle plugin to validate missing javadocs Use `./gradlew missingJavadoc` to validate missing javadocs. Currently this task fails because several modules are missing appropriate javadocs. Once added, this should pass. Also, precommit PomValidation check currently fails with missing Javadoc plugin, that needs to be fixed - #449 Thus keeping this in a separate feature branch. Signed-off-by: Himanshu Setia <[email protected]> * Fix Javadoc errors in module `client/rest` (#685) * Fix Javadoc errors in client/rest module Signed-off-by: Gregor Zurowski <[email protected]> * Add package info file in client/rest module Signed-off-by: Gregor Zurowski <[email protected]> * Fix typos Signed-off-by: Gregor Zurowski <[email protected]> * Add exception documentation to Javadoc Signed-off-by: Gregor Zurowski <[email protected]> * Fixes precommit task configuration failures due to newly added missin… (#707) * Fixes precommit task configuration failures due to newly added missingJavadoc task Signed-off-by: Himanshu Setia <[email protected]> * Fixes javadoc task errors due to PR#685 Signed-off-by: Himanshu Setia <[email protected]> * Updated CONTRIBUTING.md for info on javadocs Signed-off-by: Himanshu Setia <[email protected]> * Correcting licenses and naming Signed-off-by: Himanshu Setia <[email protected]> * Correcting version info Signed-off-by: Himanshu Setia <[email protected]> Co-authored-by: Gregor Zurowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes precommit task configuration failures due to newly added missingJavadoc task. Also fixes bug (2 errors) in #685 causing javadoc generation failures.
Signed-off-by: Himanshu Setia [email protected]
Description
The missingJavadoc task was interfering with gradle configuration lifecycle, causing the precommit tasks to be initialized incorrectly. This caused PomValidationTask to fail as it was unable to find pom files in the configured path. This PR fixes those configuration failures.
Issues Resolved
#449
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.