-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Javadoc errors in client/sniffer
#697
Fix Javadoc errors in client/sniffer
#697
Conversation
Signed-off-by: Gregor Zurowski <[email protected]>
Signed-off-by: Gregor Zurowski <[email protected]>
✅ Gradle Wrapper Validation success 50a9252 |
✅ DCO Check Passed 50a9252 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for taking care of these javadocs!
start gradle precommit |
@peterzhuamazon can we force trigger a precommit? The failure looks unrelated to the PR. |
The precommit fails because of an independent issue, #449 . Hopefully #707 should fix this. |
Hey @gzurowski thanks for your PR. |
Sure, I will rebase it as soon at #715 is merged. |
Thanks @gzurowski . I have merged #715 , you may now proceed. This PR got closed due to deletion of |
Description
Fix Javadoc comments to fix Javadoc errors as described in issue #221.
Issues Resolved
Fixes Javadoc errors in the client/rest module.
Verified by running
./gradlew :client:sniffer:missingJavadoc
.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.