Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc errors in client/sniffer #697

Conversation

gzurowski
Copy link
Contributor

Description

Fix Javadoc comments to fix Javadoc errors as described in issue #221.

Issues Resolved

Fixes Javadoc errors in the client/rest module.

Verified by running ./gradlew :client:sniffer:missingJavadoc.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 50a9252

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 50a9252

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 50a9252
Log 401

@nknize nknize added documentation Improvements or additions to documentation v1.0.0 Version 1.0.0 v2.0.0 Version 2.0.0 labels May 13, 2021
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking care of these javadocs!

@nknize
Copy link
Collaborator

nknize commented May 13, 2021

start gradle precommit

@nknize
Copy link
Collaborator

nknize commented May 13, 2021

@peterzhuamazon can we force trigger a precommit? The failure looks unrelated to the PR.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 50a9252
Log 403

@setiah
Copy link
Contributor

setiah commented May 15, 2021

@peterzhuamazon can we force trigger a precommit? The failure looks unrelated to the PR.

The precommit fails because of an independent issue, #449 . Hopefully #707 should fix this.

@setiah
Copy link
Contributor

setiah commented May 17, 2021

Hey @gzurowski thanks for your PR. javadoc branch is old and needs to be deprecated. I have opened PR #715 to merge all javadoc feature branch changes to main after fixing a few issues. Would you mind rebasing this PR on main, once #715 is merged?

@gzurowski
Copy link
Contributor Author

Hey @gzurowski thanks for your PR. javadoc branch is old and needs to be deprecated. I have opened PR #715 to merge all javadoc feature branch changes to main after fixing a few issues. Would you mind rebasing this PR on main, once #715 is merged?

Sure, I will rebase it as soon at #715 is merged.

@setiah setiah closed this May 18, 2021
@setiah setiah deleted the branch opensearch-project:javadoc May 18, 2021 20:26
@setiah
Copy link
Contributor

setiah commented May 18, 2021

Hey @gzurowski thanks for your PR. javadoc branch is old and needs to be deprecated. I have opened PR #715 to merge all javadoc feature branch changes to main after fixing a few issues. Would you mind rebasing this PR on main, once #715 is merged?

Sure, I will rebase it as soon at #715 is merged.

Thanks @gzurowski . I have merged #715 , you may now proceed. This PR got closed due to deletion of javadoc branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v1.0.0 Version 1.0.0 v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants