Upgrade the mappings on .tasks index if needed

[pbruski]

Signed-off-by: Przemek Bruski pbruskispam@op.pl

Description

Upgrade the mappings on .tasks index if needed. This fixes an regression introduced in #1732

Issues Resolved

#5376

Check List

• New functionality includes testing.
• All tests pass
• New functionality has been documented.
• New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/7324/
• CommitID: 39d1e4a

[martin-gaievski]

Is it possible to add test around this scenario so we more confident that it will not break in future releases?

[pbruski]

Is it possible to add test around this scenario so we more confident that it will not break in future releases?

How I'd do it?

1. I think the mapping update could be done regardless of the version.
2. Guarding against a change in mapping without corresponding changes in versions could be done via a commit hook.
3. Ultimately, the only real solution to this problem is a test suite that does an upgrade of OpenSearch in a baseline version to the current/master version and runs integration tests on it.

[dblock]

Since this is a regression, let's definitely figure out a way to add a test.

You'll also need to fix DCO with git commit --amend -s, thanks!

[dblock]

Let's make this look like the other lines, please?

"Fixed storing finished tasks in .tasks index"

[dblock]

Is it possible to add test around this scenario so we more confident that it will not break in future releases?

How I'd do it?

1. I think the mapping update could be done regardless of the version.
2. Guarding against a change in mapping without corresponding changes in versions could be done via a commit hook.
3. Ultimately, the only real solution to this problem is a test suite that does an upgrade of OpenSearch in a baseline version to the current/master version and runs integration tests on it.

We have bcw tests exactly for this scenario! I've never written one myself, but if you can't figure it out we'll find someone to help. Start here: https://opensearch.org/blog/technical-post/2021/11/bwc-testing-for-opensearch/

[andrross]

@pbruski Thanks for the contribution here! I've gone ahead and created #5412 which takes your fix here as well as modifies the existing compatibility test to catch these types of problems in the future.

[andrross]

Closing as this has been resolved in #5412

Thanks again @pbruski !

[pbruski]

@andrross Thanks for taking this over - honestly, I have no idea when I'd find the time to dig into the test infra and write that test...