Adding a cancelled field to tell if a cancellable task is cancelled - #1732
Merged
Conversation
meghasaik
changed the title
5 tasks
Contributor
|
Can one of the admins verify this patch? |
Signed-off-by: meghasaik <kavmegha@amazon.com>
Contributor
|
❌ Gradle Check failure e30f75f5affbaea1b0e497287fc4c9a555eed435 |
dblock
approved these changes
Dec 15, 2021
| Map<String, String> headers | ||
| ) { | ||
| if (cancellable == false && cancelled == true) { | ||
| throw new IllegalArgumentException("uncancellable task cannot be cancelled"); |
Member
There was a problem hiding this comment.
I think it should just say "task cannot be cancelled", it implies the former
| cancelled = false; | ||
| } | ||
| if (cancellable == false && cancelled == true) { | ||
| throw new IllegalArgumentException("uncancellable task cannot be cancelled"); |
Member
I think you need to rebase another version update commit. |
Signed-off-by: meghasaik <kavmegha@amazon.com>
andrross
approved these changes
Dec 15, 2021
6 tasks
Member
|
@meghasaik FYI, there was a regression in this PR, see #5377 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Megha Sai Kavikondala kavmegha@amazon.com
Description
A cancelled field is added which tells if the cancellable task is cancelled. At some points, even if the cancellable task is cancelled it still runs, so to show that the task is cancelled, a cancelled field is shown in the tasks API, cancelled:true .
Issues Resolved
#520
Check List
New functionality includes testing.
All tests pass
New functionality has been documented.
New functionality has javadoc added
Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.