-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Omit maxScoreCollector in SimpleTopDocsCollectorContext when concurrent segment search enabled #19584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit maxScoreCollector in SimpleTopDocsCollectorContext when concurrent segment search enabled #19584
Conversation
…nt segment search enabled Signed-off-by: Binlong Gao <[email protected]>
Signed-off-by: Binlong Gao <[email protected]>
|
❌ Gradle check result for 5b0a90f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5b0a90f: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 5b0a90f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19584 +/- ##
=========================================
Coverage 73.05% 73.05%
+ Complexity 70627 70618 -9
=========================================
Files 5723 5723
Lines 323489 323490 +1
Branches 46851 46852 +1
=========================================
+ Hits 236311 236326 +15
+ Misses 68174 68098 -76
- Partials 19004 19066 +62 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…nt segment search enabled (opensearch-project#19584) * Omit maxScoreCollector in SimpleTopDocsCollectorContext when concurrent segment search enabled Signed-off-by: Binlong Gao <[email protected]> * Modify changelog Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
…nt segment search enabled (opensearch-project#19584) * Omit maxScoreCollector in SimpleTopDocsCollectorContext when concurrent segment search enabled Signed-off-by: Binlong Gao <[email protected]> * Modify changelog Signed-off-by: Binlong Gao <[email protected]> --------- Signed-off-by: Binlong Gao <[email protected]>
Description
Similar to #19181, in SimpleTopDocsCollectorContext, when concurrent segment search is enabled, we can also omit the maxScoreCollector if score is the primary sort.
This change is small, and the existing tests can cover the change. Below are the benchmark result:
Related Issues
No issue.
Check List
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.