Skip to content

Pack terms once when terms query is created for indexed and docValues… #19350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jainankitk merged 6 commits into from
Oct 9, 2025
Merged

Pack terms once when terms query is created for indexed and docValues… #19350

jainankitk merged 6 commits into from
Oct 9, 2025

Conversation

@mkhludnev
Copy link
Contributor

@mkhludnev mkhludnev commented Sep 20, 2025 •
edited
Loading

… keyword field.

Description

Pack terms once when terms query is created for indexed and docValues keywords field.

Related Issues

It's a continuation of #17714 made possible by lucene#14425

Check List

  • [v] Functionality includes testing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mkhludnev mkhludnev force-pushed the keyword-idx-dv-termsQ-sort-once branch from 7f1cd7e to 9e66c4a Compare September 20, 2025 21:32
@mkhludnev mkhludnev force-pushed the keyword-idx-dv-termsQ-sort-once branch from 9e66c4a to e8f9e61 Compare September 20, 2025 21:33
@mkhludnev
Copy link
Contributor Author

mkhludnev commented Sep 20, 2025

fwiw this optimization doesn't work for flattened field type.

@mkhludnev mkhludnev changed the title Sort terms once when terms query is created for indexed and docValues… Pack pre-sorted terms once when terms query is created for indexed and docValues… Sep 20, 2025
@mkhludnev mkhludnev changed the title Pack pre-sorted terms once when terms query is created for indexed and docValues… Pack terms once when terms query is created for indexed and docValues… Sep 20, 2025
@mkhludnev
Clarify CHANGELOG.md
b8819fd 
Signed-off-by: Mikhail Khludnev <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2025

❌ Gradle check result for b8819fd: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 20, 2025
Open
@mkhludnev
Copy link
Contributor Author

mkhludnev commented Sep 21, 2025

something is wrong with failed job

{"pr_from_sha": "b8819fd815e4082ca79c799602369fccb10452a8", "pr_from_clone_url": "https://github.com/mkhludnev/OpenSearch.git", "pr_to_clone_url": "https://github.com/opensearch-project/OpenSearch.git", "pr_title": "pack terms once when terms query is created for indexed and docvalues", "pr_number": "19350", "post_merge_action": "false", "pr_owner": "mkhludnev"}
<html>
 <head><title>403 Forbidden</title></head>
 <body>
 <center><h1>403 Forbidden</h1></center>
 </body>
 </html>
jq: parse error: Invalid numeric literal at line 1, column 7
QUEUE_URL

@mkhludnev
more testing
c5d23c9 
Signed-off-by: Mikhail Khludnev <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

❌ Gradle check result for c5d23c9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 22, 2025
Closed
Closed
@mkhludnev
Copy link
Contributor Author

mkhludnev commented Sep 23, 2025 •
edited
Loading

reproduced failure StreamStringTermsAggregatorTests.testReduceWithSizeLimit locally. looking into

UPD ok. it seems unrelated.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2025

❌ Gradle check result for e65a5c1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

✅ Gradle check result for e2828ae: SUCCESS

@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.01%. Comparing base (39b7a59) to head (e2828ae).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #19350   +/-   ##
=========================================
  Coverage     73.00%   73.01%           
- Complexity    70534    70542    +8     
=========================================
  Files          5719     5719           
  Lines        323260   323272   +12     
  Branches      46816    46821    +5     
=========================================
+ Hits         235993   236030   +37     
+ Misses        68224    68188   -36     
- Partials      19043    19054   +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

jainankitk
jainankitk approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mkhludnev for patiently waiting for apache/lucene#14435 to be available as part of 10.3 upgrade and adding this improvement!

@jainankitk jainankitk merged commit 9f7c73b into opensearch-project:main Oct 9, 2025
33 checks passed
rgsriram pushed a commit to rgsriram/OpenSearch that referenced this pull request Oct 11, 2025
@mkhludnev @rgsriram
Pack terms once when terms query is created for indexed and docValu…
ed17b98 
…es… (opensearch-project#19350)

Signed-off-by: Mikhail Khludnev <[email protected]>
Signed-off-by: Mikhail Khludnev <[email protected]>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
@mkhludnev
Pack terms once when terms query is created for indexed and docValu…
0372f96 
…es… (opensearch-project#19350)

Signed-off-by: Mikhail Khludnev <[email protected]>
Signed-off-by: Mikhail Khludnev <[email protected]>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Oct 22, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

Assignees

No one assigned

Labels

lucene

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkhludnev @jainankitk