[Engine] make Engine.Result#setTransLogLocation() setTook() freeze() … #19275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinny-Wang
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
…public Signed-off-by: jinnyw <[email protected]>
Jinny-Wang
force-pushed
the
publicize-engine-calls
branch
from
c194078 to
b06de0c
Compare
Signed-off-by: jinnyw <[email protected]>
Contributor
Author
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19275 +/- ##
============================================
+ Coverage 72.92% 72.94% +0.01%
+ Complexity 69779 69778 -1
============================================
Files 5665 5665
Lines 320521 320521
Branches 46396 46396
============================================
+ Hits 233739 233791 +52
+ Misses 67854 67840 -14
+ Partials 18928 18890 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yupeng9
approved these changes
Sep 12, 2025
Contributor
yupeng9
left a comment
yupeng9
left a comment
There was a problem hiding this comment.
this looks reasonably safe change to me
msfroh
approved these changes
Sep 12, 2025
Contributor
msfroh
left a comment
msfroh
left a comment
There was a problem hiding this comment.
Given that we have the freeze method already to lock down these mutators, making them public should only open them up to custom Engine implementations, which is the whole point of this PR.
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
opensearch-project#19275) Make Engine.Result#setTransLogLocation(), setTook(), and freeze() public so that they can be called from plugins that implement a custom Engine. --------- Signed-off-by: jinnyw <[email protected]> Co-authored-by: jinnyw <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
opensearch-project#19275) Make Engine.Result#setTransLogLocation(), setTook(), and freeze() public so that they can be called from plugins that implement a custom Engine. --------- Signed-off-by: jinnyw <[email protected]> Co-authored-by: jinnyw <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
jainankitk
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 22, 2025
opensearch-project#19275) Make Engine.Result#setTransLogLocation(), setTook(), and freeze() public so that they can be called from plugins that implement a custom Engine. --------- Signed-off-by: jinnyw <[email protected]> Co-authored-by: jinnyw <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
asimmahmood1
pushed a commit
to jainankitk/OpenSearch
that referenced
this pull request
Sep 23, 2025
opensearch-project#19275) Make Engine.Result#setTransLogLocation(), setTook(), and freeze() public so that they can be called from plugins that implement a custom Engine. --------- Signed-off-by: jinnyw <[email protected]> Co-authored-by: jinnyw <[email protected]>
pranikum
pushed a commit
to pranikum/OpenSearch
that referenced
this pull request
Sep 23, 2025
opensearch-project#19275) Make Engine.Result#setTransLogLocation(), setTook(), and freeze() public so that they can be called from plugins that implement a custom Engine. --------- Signed-off-by: jinnyw <[email protected]> Co-authored-by: jinnyw <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
opensearch-project#19275) Make Engine.Result#setTransLogLocation(), setTook(), and freeze() public so that they can be called from plugins that implement a custom Engine. --------- Signed-off-by: jinnyw <[email protected]> Co-authored-by: jinnyw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Issue #19276