-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add StoreFactory plugin interface for custom Store implementations #19091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+244
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xuxiong1 <[email protected]>
Contributor
Author
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19091 +/- ##
============================================
- Coverage 72.93% 72.86% -0.08%
- Complexity 69411 69420 +9
============================================
Files 5647 5647
Lines 319139 319161 +22
Branches 46163 46165 +2
============================================
- Hits 232775 232544 -231
- Misses 67502 67812 +310
+ Partials 18862 18805 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yupeng9
reviewed
Aug 18, 2025
Signed-off-by: xuxiong1 <[email protected]>
Contributor
yupeng9
approved these changes
Aug 19, 2025
msfroh
approved these changes
Aug 19, 2025
This was referenced Aug 19, 2025
atris
pushed a commit
to atris/OpenSearch
that referenced
this pull request
Aug 28, 2025
…pensearch-project#19091) * Add StoreFactory plugin interface for custom Store implementations Signed-off-by: xuxiong1 <[email protected]> * Resolve comments Signed-off-by: xuxiong1 <[email protected]> --------- Signed-off-by: xuxiong1 <[email protected]>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
…pensearch-project#19091) * Add StoreFactory plugin interface for custom Store implementations Signed-off-by: xuxiong1 <[email protected]> * Resolve comments Signed-off-by: xuxiong1 <[email protected]> --------- Signed-off-by: xuxiong1 <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…pensearch-project#19091) * Add StoreFactory plugin interface for custom Store implementations Signed-off-by: xuxiong1 <[email protected]> * Resolve comments Signed-off-by: xuxiong1 <[email protected]> --------- Signed-off-by: xuxiong1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Enhancement or improvement to existing feature or request
Indexing:Replication
Issues and PRs related to core replication framework eg segrep
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables plugins to provide custom Store implementations per index.
INDEX_STORE_FACTORY_SETTINGto allow plugins to provide custom Store factoriesIndexServiceto use pluggableStoreFactoryfor shard Store creationStore.LoadedMetadataandStore.OnClosepublic API for custom store plugin developersindex.store.factorysetting with fallback to default StoreWill have a PR later to actually implement the Store plugin, which would have a custom store implementation to handle files outside the default store
indexdirectory.Related Issues
Resolves #19090
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.