-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Grant access to testclusters dir for tests #19085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant access to testclusters dir for tests #19085
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
|
❌ Gradle check result for 5c05514: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19085 +/- ##
============================================
- Coverage 72.94% 72.91% -0.04%
+ Complexity 69523 69458 -65
============================================
Files 5647 5647
Lines 319166 319166
Branches 46165 46165
============================================
- Hits 232828 232714 -114
- Misses 67539 67601 +62
- Partials 18799 18851 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
* Grant access to testclusters dir for tests Signed-off-by: Craig Perkins <[email protected]> * Fix CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
* Grant access to testclusters dir for tests Signed-off-by: Craig Perkins <[email protected]> * Fix CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
* Grant access to testclusters dir for tests Signed-off-by: Craig Perkins <[email protected]> * Fix CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
* Grant access to testclusters dir for tests Signed-off-by: Craig Perkins <[email protected]> * Fix CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Description
Similar to #18988, this PR resolves an issue seen in CCR repo seen on the 3.3 version increment: opensearch-project/cross-cluster-replication#1571
One of the tests reads a classpath resource and then copies to the config directory of one of the testclusters and fails bc the javaagent is forbidding it from writing. See the relevant test lines here: https://github.com/opensearch-project/cross-cluster-replication/blob/main/src/test/kotlin/org/opensearch/replication/integ/rest/StartReplicationIT.kt#L628-L635
Fixes the following error:
One small change would still be necessary on CCR side to add a systemProp when running integTests:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.