Ensure that plugins that utilize dumpCoverage can write to jacoco.dir when tests.security.manager is enabled #18988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when tests.security.manager is enabled Signed-off-by: Craig Perkins <[email protected]>
5 tasks
cwperks
changed the title
Signed-off-by: Craig Perkins <[email protected]>
Contributor
|
❌ Gradle check result for dc88680: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for dc88680: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Aug 7, 2025
Signed-off-by: Craig Perkins <[email protected]>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18988 +/- ##
============================================
- Coverage 72.93% 72.92% -0.02%
+ Complexity 69469 69440 -29
============================================
Files 5647 5647
Lines 319013 319061 +48
Branches 46151 46151
============================================
- Hits 232663 232662 -1
- Misses 67561 67597 +36
- Partials 18789 18802 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
Contributor
andrross
approved these changes
Aug 12, 2025
3 tasks
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
… when tests.security.manager is enabled (opensearch-project#18988) Signed-off-by: Craig Perkins <[email protected]>
atris
pushed a commit
to atris/OpenSearch
that referenced
this pull request
Aug 28, 2025
… when tests.security.manager is enabled (opensearch-project#18988) Signed-off-by: Craig Perkins <[email protected]>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
… when tests.security.manager is enabled (opensearch-project#18988) Signed-off-by: Craig Perkins <[email protected]>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
… when tests.security.manager is enabled (opensearch-project#18988) Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensure that plugins that utilize dumpCoverage can write to jacoco.dirwhen tests.security.manager is enabled.
This pattern is used to adequately get code coverage for integ tests that utilize testClusters by probing the in memory nodes to see what lines are hit.
Every instance I have found of using testclusters runs with
tests.security.managerset to false and I'd like to encourage all plugins to now test with the javaagent by default so they need write permission to the jacoco dir.Tested using the job-scheduler. Companion JS PR: opensearch-project/job-scheduler#809
Note: the checks on the companion PR will fail until this one is merged.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.