-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add false_allow_templates as a dynamic mapping option
#19065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add false_allow_templates as a dynamic mapping option
#19065
Conversation
Signed-off-by: Bruce Hong <[email protected]>
c23067a to
a18dd07
Compare
false_allow_templates as a dynamic mapping optionfalse_allow_templates as a dynamic mapping option
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19065 +/- ##
============================================
+ Coverage 72.87% 72.94% +0.07%
- Complexity 69380 69432 +52
============================================
Files 5647 5647
Lines 319084 319106 +22
Branches 46157 46163 +6
============================================
+ Hits 232528 232778 +250
+ Misses 67729 67466 -263
- Partials 18827 18862 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @gaobinlong not sure if you wanted to take another look. This is an exact copy of the previous with a few test cases removed. |
|
Thanks for the quick fix @bruce-hong-glean! |
…ch-project#19065) Signed-off-by: Bruce Hong <[email protected]>
…ch-project#19065) Signed-off-by: Bruce Hong <[email protected]>
…ch-project#19065) Signed-off-by: Bruce Hong <[email protected]>
…ch-project#19065) Signed-off-by: Bruce Hong <[email protected]>
…ch-project#19065) Signed-off-by: Bruce Hong <[email protected]>
Description
This PR adds the
dynamic: false_allow_templatesoption to the schema. This creates mappings for any field that matchespropertiesordynamic_templates, and ignores any fields that do not (as opposed to rejecting altogether).Example from linked issue, the usage is:
urlmatches an explicit property and the fieldsdate_timestampanddate_timezonemath the dynamic template:This is a redo of the reverted PR here, with invalid tests removed.
Related Issues
Resolves #18617
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.