-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add false_allow_templates as a dynamic mapping option #18825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add false_allow_templates as a dynamic mapping option #18825
Conversation
|
❌ Gradle check result for 4f37b48: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0a6476a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: gaobinlong <[email protected]>
Signed-off-by: Bruce Hong <[email protected]>
…uce-hong-glean/OpenSearch into false-allow-dynamic-templates
|
❕ Gradle check result for 0eebef1: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Bruce Hong <[email protected]>
|
❌ Gradle check result for a632fd3: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…arch-project#18825)" This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
…" (#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
…ject#18825) * Starting work, untested Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <[email protected]> * Rebase Signed-off-by: Bruce Hong <[email protected]> * Fix rest-api-spec:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Run :server:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Improve test coverage Signed-off-by: Bruce Hong <[email protected]> * Spotless apply Signed-off-by: Bruce Hong <[email protected]> * DRY-er Signed-off-by: Bruce Hong <[email protected]> * Spotless check Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> --------- Signed-off-by: Bruce Hong <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
…ject#18825) * Starting work, untested Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <[email protected]> * Rebase Signed-off-by: Bruce Hong <[email protected]> * Fix rest-api-spec:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Run :server:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Improve test coverage Signed-off-by: Bruce Hong <[email protected]> * Spotless apply Signed-off-by: Bruce Hong <[email protected]> * DRY-er Signed-off-by: Bruce Hong <[email protected]> * Spotless check Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> --------- Signed-off-by: Bruce Hong <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
…ject#18825) * Starting work, untested Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <[email protected]> * Rebase Signed-off-by: Bruce Hong <[email protected]> * Fix rest-api-spec:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Run :server:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Improve test coverage Signed-off-by: Bruce Hong <[email protected]> * Spotless apply Signed-off-by: Bruce Hong <[email protected]> * DRY-er Signed-off-by: Bruce Hong <[email protected]> * Spotless check Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> --------- Signed-off-by: Bruce Hong <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
…ject#18825) * Starting work, untested Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <[email protected]> * Rebase Signed-off-by: Bruce Hong <[email protected]> * Fix rest-api-spec:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Run :server:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Improve test coverage Signed-off-by: Bruce Hong <[email protected]> * Spotless apply Signed-off-by: Bruce Hong <[email protected]> * DRY-er Signed-off-by: Bruce Hong <[email protected]> * Spotless check Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> --------- Signed-off-by: Bruce Hong <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
…ject#18825) * Starting work, untested Update tests Tests Tests Cleanup Tested, cleanup Cleanup Signed-off-by: Bruce Hong <[email protected]> * Rebase Signed-off-by: Bruce Hong <[email protected]> * Fix rest-api-spec:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Run :server:spotlessApply Signed-off-by: Bruce Hong <[email protected]> * Improve test coverage Signed-off-by: Bruce Hong <[email protected]> * Spotless apply Signed-off-by: Bruce Hong <[email protected]> * DRY-er Signed-off-by: Bruce Hong <[email protected]> * Spotless check Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> * Comments Signed-off-by: Bruce Hong <[email protected]> --------- Signed-off-by: Bruce Hong <[email protected]> Signed-off-by: gaobinlong <[email protected]> Co-authored-by: gaobinlong <[email protected]>
…arch-project#18825)" (opensearch-project#19061) This reverts commit 9f28ef8. Lots of test failures blocking PRs for the newly added yaml test. Signed-off-by: Andrew Ross <[email protected]>
Description
This PR adds the
dynamic: false_allow_templatesoption to the schema. This creates mappings for any field that matchespropertiesordynamic_templates, and ignores any fields that do not (as opposed to rejecting altogether).Example from linked issue, the usage is:
urlmatches an explicit property and the fieldsdate_timestampanddate_timezonemath the dynamic template:Related Issues
Resolves #18617
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.