Skip to content

[Backport 3.2] Fix max_score yaml test is skipped #19050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

[Backport 3.2] Fix max_score yaml test is skipped #19050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions rest-api-spec/src/main/resources/rest-api-spec/test/search/400_max_score.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,33 +33,35 @@ teardown:
---
"Test max score with sorting on score firstly":
- skip:
version: " - 3.2.0"
version: " - 3.1.99"
reason: Fixed in 3.2.0

- do:
search:
rest_total_hits_as_int: true
index: test_1
body:
query: { term: { foo: bar} }
sort: [{ _score: desc }, { _doc: desc }]
- match: { hits.total: 2 }
- length: { hits.hits: 2 }
- match: { max_score: 1.0 }
- match: { hits.max_score: 1.0 }

- do:
search:
rest_total_hits_as_int: true
index: test_1
body:
query: { term: { foo: bar} }
sort: [{ _score: asc }, { _doc: desc }]
- match: { hits.total: 2 }
- length: { hits.hits: 2 }
- match: { max_score: null }
- match: { hits.max_score: null }

---
"Test max score with sorting on score firstly with concurrent segment search enabled":
- skip:
version: " - 3.2.0"
version: " - 3.1.99"
reason: Fixed in 3.2.0

- do:
Expand All @@ -70,20 +72,22 @@ teardown:

- do:
search:
rest_total_hits_as_int: true
index: test_1
body:
query: { term: { foo: bar} }
sort: [{ _score: desc }, { _doc: desc }]
- match: { hits.total: 2 }
- length: { hits.hits: 2 }
- match: { max_score: 1.0 }
- match: { hits.max_score: 1.0 }

- do:
search:
rest_total_hits_as_int: true
index: test_1
body:
query: { term: { foo: bar} }
sort: [{ _score: asc }, { _doc: desc }]
- match: { hits.total: 2 }
- length: { hits.hits: 2 }
- match: { max_score: null }
- match: { hits.max_score: null }
Loading