[Backport 3.2] Fix max_score yaml test is skipped #19050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Binlong Gao <[email protected]>
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.2 #19050 +/- ##
============================================
- Coverage 72.93% 72.85% -0.08%
+ Complexity 69352 69347 -5
============================================
Files 5643 5645 +2
Lines 318713 318779 +66
Branches 46112 46123 +11
============================================
- Hits 232441 232249 -192
- Misses 67488 67769 +281
+ Partials 18784 18761 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
andrross
approved these changes
Aug 14, 2025
Member
|
Let's hold off on merging this until after the 3.2 release just to avoid any confusion around last minute changes. This is just a test fix so it's not needed for the release but it's fine to backport just so we have good test coverage on this branch in case there are any subsequent patch releases. |
sandeshkr419
approved these changes
Aug 18, 2025
mch2
pushed a commit
to mch2/OpenSearch
that referenced
this pull request
Sep 26, 2025
Signed-off-by: Binlong Gao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The skip version in 400_max_score.yml is not correct, that causes the tests are skipped, this PR fixes the version and also fixes the test failure.
Related Issues
No issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.