[Pull-based Ingestion] Add warning when message is dropped #18304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18304 +/- ##
============================================
- Coverage 72.51% 72.49% -0.02%
+ Complexity 67379 67364 -15
============================================
Files 5488 5488
Lines 311062 311068 +6
Branches 45217 45217
============================================
- Hits 225552 225509 -43
- Misses 67132 67187 +55
+ Partials 18378 18372 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Varun Bharadwaj <[email protected]>
varunbharadwaj
force-pushed
the
vb/errormsg
branch
from
bf6f257 to
ec3c1a0
Compare
yupeng9
approved these changes
May 15, 2025
andrross
reviewed
May 15, 2025
server/src/main/java/org/opensearch/indices/pollingingest/MessageProcessorRunnable.java
Show resolved
Hide resolved
andrross
approved these changes
May 15, 2025
tanik98
pushed a commit
to tanik98/OpenSearch
that referenced
this pull request
May 27, 2025
Signed-off-by: Varun Bharadwaj <[email protected]>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
Signed-off-by: Varun Bharadwaj <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Varun Bharadwaj <[email protected]>Signed-off-by: TJ Neuenfeldt <[email protected]>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
Signed-off-by: Varun Bharadwaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a warning log indicating the ID and message pointer when a message is dropped after exhausting retries. This log is required for users to identify and retry the message manually if required, until DLQ support is added.
Related Issues
Follow up of #17085
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.