Skip to content

[Feature Request] Error handling for pull-based ingestion #17085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
varunbharadwaj opened this issue Jan 22, 2025 · 1 comment · Fixed by #17427
Closed

[Feature Request] Error handling for pull-based ingestion #17085

varunbharadwaj opened this issue Jan 22, 2025 · 1 comment · Fixed by #17427
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing

Comments

@varunbharadwaj
Copy link
Contributor

varunbharadwaj commented Jan 22, 2025

Is your feature request related to a problem? Please describe

Handle failure scenarios in pull-based ingestion. Failures during pull-based ingestion could be due to multiple reasons, like a malformed message or a poison pill. Handle failure scenarios with sufficient observability into the errors.

Describe the solution you'd like

Create ingestion error handling strategy interface and support following two error handling modes to begin with:

  1. Drop: This will be used if failures can be ignored and it is possible to continue processing remaining updates in the ingestion source.
  2. Block: This will be used if failures cannot be tolerated and ingestion must be halted till the issue is fixed.

The error handler strategies will also provide flexibility to log errors, record bad messages and emit metrics. In future, it can be extended to write to a DLQ when required.

Related component

Indexing

Describe alternatives you've considered

No response

Additional context

No response

@varunbharadwaj varunbharadwaj added enhancement Enhancement or improvement to existing feature or request untriaged labels Jan 22, 2025
@github-actions github-actions bot added the Indexing Indexing, Bulk Indexing and anything related to indexing label Jan 22, 2025
@andrross
Copy link
Member

Catch All Triage - 1, 2, 3, 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants