Skip to content

[Backport 2.x] [Bugfix] Fix cache maximum size settings not working properly with pluggable caching#17042

Merged
jainankitk merged 3 commits intoopensearch-project:2.xfrom
peteralfonsi:backport-16636-to-2.x
Jan 28, 2025
Merged

[Backport 2.x] [Bugfix] Fix cache maximum size settings not working properly with pluggable caching#17042
jainankitk merged 3 commits intoopensearch-project:2.xfrom
peteralfonsi:backport-16636-to-2.x

Conversation

@peteralfonsi
Copy link
Contributor

@peteralfonsi peteralfonsi commented Jan 16, 2025

Backport a436076 from #16636.

@peteralfonsi @jainankitk
[Bugfix] Fix cache maximum size settings not working properly with pl…
5e4ef9f 
…uggable caching (opensearch-project#16636)

* Fix cache size setting

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* Changelog

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* Deprecate original IRC size setting

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* spotlessApply

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* Addressed Ankit's comments

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

* Address Sagar's comment

Signed-off-by: Peter Alfonsi <petealft@amazon.com>

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Signed-off-by: Peter Alfonsi <peter.alfonsi@gmail.com>
Signed-off-by: Ankit Jain <akjain@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Ankit Jain <akjain@amazon.com>
(cherry picked from commit a436076)
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025

❌ Gradle check result for 5e4ef9f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 17, 2025
Closed
@peteralfonsi
Copy link
Contributor Author

peteralfonsi commented Jan 22, 2025

Flaky test: #15944

Merge remote-tracking branch 'upstream/2.x' into backport-16636-to-2.x
00a5bfc 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@peteralfonsi peteralfonsi requested a review from cwperks as a code owner January 22, 2025 22:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2025

❌ Gradle check result for 00a5bfc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 22, 2025
Open
@peteralfonsi
Copy link
Contributor Author

peteralfonsi commented Jan 27, 2025

Flaky test: #14324

rerun gradle
35a180b 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025

❕ Gradle check result for 35a180b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (bd885f7) to head (35a180b).
Report is 21 commits behind head on 2.x.

Files with missing lines Patch % Lines
...va/org/opensearch/indices/IndicesRequestCache.java 86.95% 3 Missing ⚠️
.../opensearch/common/cache/service/CacheService.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17042      +/-   ##
============================================
+ Coverage     71.84%   71.90%   +0.06%     
- Complexity    65595    65657      +62     
============================================
  Files          5318     5319       +1     
  Lines        305846   305944      +98     
  Branches      44602    44619      +17     
============================================
+ Hits         219739   219994     +255     
+ Misses        67752    67679      -73     
+ Partials      18355    18271      -84

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 28, 2025
Open
@jainankitk jainankitk merged commit 64486b6 into opensearch-project:2.x Jan 28, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jainankitk jainankitk jainankitk approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peteralfonsi @jainankitk