[Bugfix] Fix cache maximum size settings not working properly with pluggable caching

[peteralfonsi]

Description

Fixes a bug (#16631) where max size settings for cache implementations were not working correctly when pluggable caching is on.

The cache implementations like OpenSearchOnHeapCache had been changed so that the max size value from the config overrode the value from their setting. This allowed the TieredSpilloverCache to send different sizes into the cache config when constructing its segments. However, the IndicesRequestCache was also putting its default 1% of heap size value into the cache config, and this overrode the setting values even when pluggable caching was on.

Fixes this by having the IRC only put a max size value into the config if pluggable caching is off.

Adds UTs around this. Also tested manually with different combinations of settings.

Related Issues

Resolves #16631

Check List

• Functionality includes testing.
• [N/A] API changes companion pull request created, if applicable.
• [N/A] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

✅ Gradle check result for 3d1fe73: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.70%. Comparing base (e7e19f7) to head (c518d58).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...va/org/opensearch/indices/IndicesRequestCache.java	86.95%	3 Missing ⚠️
.../opensearch/common/cache/service/CacheService.java	85.71%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16636      +/-   ##
============================================
+ Coverage     72.20%   72.70%   +0.49%     
- Complexity    65289    65642     +353     
============================================
  Files          5299     5299              
  Lines        303536   303544       +8     
  Branches      43941    43943       +2     
============================================
+ Hits         219180   220684    +1504     
+ Misses        66441    65101    -1340     
+ Partials      17915    17759     -156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

❌ Gradle check result for 469006a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 76ad2ef: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[peteralfonsi]

Flaky tests: #14568, #16015

[github-actions]

❌ Gradle check result for c75fb9f:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for db3e068: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 8ea8f07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 7f9c5f5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❕ Gradle check result for ff2f1e5: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

✅ Gradle check result for c518d58: SUCCESS