Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Refactor new home page #8467

Merged
merged 21 commits into from
Oct 8, 2024
Merged

[Workspace] Refactor new home page #8467

merged 21 commits into from
Oct 8, 2024

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Oct 3, 2024 •
edited by SuZhou-Joe
Loading

Description

Refactor new home page.
The new home page will show use case card, workspace list, use case information flyout, create workspace button for OSD admin, view workspace button, tools button, setting button and user information.

  1. For the order of workspace list, it should show recently visited first, then other workspaces alphabetically.
  2. Clicking the information icon will show the use case information
  3. Clicking the create button will preselect the use case in the workspace create page;
  4. Clicking the view all button will preselect the use case in the workspace list page;

Issues Resolved

Screenshot

2024-10-03.15.23.43.mp4

Dark mode

image

Testing the changes

opensearchDashboards.dashboardAdmin.users: ["admin"]
workspace.enabled: true 
opensearch.hosts: ["https://localhost:9200"]
opensearch.username: "admin"
opensearch.password: "myStrongPassword!" 
opensearch.ssl.verificationMode: none
savedObjects.permission.enabled: true

uiSettings:
   overrides:
     "home:useNewHomePage": true

Changelog

  • refactor: [Workspace] Refactor new home page.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
update home page
87675e7 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
ec154c7 
…oards into 2.17/support-home-page
@yubonluo
updated useCase card in workspace initial page
2bfce17 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
slove code conflict
791b9fe 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
Integrate use case flyout and add unit tests
4b53dd9 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
94c9ce9 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
b2dbac5 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
1fc8742 
…oards into 2.17/support-home-page
@yubonluo
implemet populate use case when clicking create/view button
a03a678 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
2cda714 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
delete useless code
dfad00f 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
c2e999a 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
solve code conflict
46817c6 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
update snap shot
b4bad50 
Signed-off-by: yubonluo <[email protected]>
ruanyl
ruanyl reviewed Oct 7, 2024
View reviewed changes
src/plugins/workspace/public/components/workspace_initial/utils.ts Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx Outdated Show resolved Hide resolved
src/plugins/workspace/public/components/workspace_initial/workspace_initial.tsx Show resolved Hide resolved
@yubonluo
optimize the code
04695da 
Signed-off-by: yubonluo <[email protected]>
@yubonluo
optimize the code
601bfa3 
Signed-off-by: yubonluo <[email protected]>
ruanyl
ruanyl previously approved these changes Oct 8, 2024
View reviewed changes
@ruanyl
Copy link
Member

ruanyl commented Oct 8, 2024

@yubonluo It looks the CI failed on i18n validation

@SuZhou-Joe SuZhou-Joe merged commit 61eedf7 into opensearch-project:main Oct 8, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 8, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Refactor new home page (#8467)
84a7422 
* update home page

Signed-off-by: yubonluo <[email protected]>

* updated useCase card in workspace initial page

Signed-off-by: yubonluo <[email protected]>

* Integrate use case flyout and add unit tests

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* implemet populate use case when clicking create/view button

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #8467 created/updated

* update css

Signed-off-by: yubonluo <[email protected]>

* fix the test errors

Signed-off-by: yubonluo <[email protected]>

* delete useless code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* update snap shot

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* fix i18n validation error

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 61eedf7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 8, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Oct 8, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Refactor new home page (#8467) (#8523)
1063072 
* update home page



* updated useCase card in workspace initial page



* Integrate use case flyout and add unit tests



* optimize the code



* optimize the code



* implemet populate use case when clicking create/view button



* optimize the code



* Changeset file for PR #8467 created/updated

* update css



* fix the test errors



* delete useless code



* optimize the code



* update snap shot



* optimize the code



* optimize the code



* fix i18n validation error



---------



(cherry picked from commit 61eedf7)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@amsiglan amsiglan mentioned this pull request Oct 25, 2024
Merged
7 tasks
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x v2.18.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yubonluo @ruanyl @SuZhou-Joe @ananzh