-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Saved queries new UI (#8469) #8705
Conversation
* loading query functional Signed-off-by: Amardeepsingh Siglani <[email protected]> * search bar working; save working Signed-off-by: Amardeepsingh Siglani <[email protected]> * implemented pagination Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR opensearch-project#8469 created/updated * implemented tab for template queries; updated UI elements for new mocks Signed-off-by: Amardeepsingh Siglani <[email protected]> * added i18n; minor refactors Signed-off-by: Amardeepsingh Siglani <[email protected]> * refactored css Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed comments Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed i18n error Signed-off-by: Amardeepsingh Siglani <[email protected]> * show template queries tab only when templates present Signed-off-by: Amardeepsingh Siglani <[email protected]> * addressed PR comments Signed-off-by: Amardeepsingh Siglani <[email protected]> * fixed unit tests Signed-off-by: Amardeepsingh Siglani <[email protected]> * introduced a new gate for the changes Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8705 +/- ##
==========================================
- Coverage 60.93% 60.84% -0.10%
==========================================
Files 3792 3797 +5
Lines 90507 90671 +164
Branches 14209 14251 +42
==========================================
+ Hits 55153 55168 +15
- Misses 31868 32012 +144
- Partials 3486 3491 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving assuming ci passes
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Description
Backport #8469 to 2.x
Check List
yarn test:jest
yarn test:jest_integration