Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Saved queries new UI (#8469) #8705

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

amsiglan
Copy link
Collaborator

@amsiglan amsiglan commented Oct 25, 2024

Description

Backport #8469 to 2.x

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* loading query functional

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* search bar working; save working

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* implemented pagination

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Changeset file for PR opensearch-project#8469 created/updated

* implemented tab for template queries; updated UI elements for new mocks

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added i18n; minor refactors

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* refactored css

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed i18n error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* show template queries tab only when templates present

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* addressed PR comments

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed unit tests

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* introduced a new gate for the changes

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 7.04846% with 211 lines in your changes missing coverage. Please review.

Project coverage is 60.84%. Comparing base (ac7bf02) to head (2773848).
Report is 8 commits behind head on 2.x.

Files with missing lines Patch % Lines
...lugins/data/public/ui/saved_query_form/helpers.tsx 0.00% 64 Missing ⚠️
...ui/saved_query_flyouts/open_saved_query_flyout.tsx 0.00% 63 Missing ⚠️
...public/ui/saved_query_flyouts/saved_query_card.tsx 0.00% 42 Missing ⚠️
...ry_management/saved_query_management_component.tsx 21.42% 10 Missing and 1 partial ⚠️
...ta/public/query/saved_query/saved_query_service.ts 56.25% 4 Missing and 3 partials ⚠️
...ublic/ui/saved_query_flyouts/save_query_flyout.tsx 0.00% 7 Missing ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx 0.00% 5 Missing ⚠️
...ugins/data/public/ui/filter_bar/filter_options.tsx 0.00% 2 Missing and 2 partials ⚠️
src/plugins/data/public/plugin.ts 0.00% 3 Missing ⚠️
...ata/public/ui/saved_query_form/save_query_form.tsx 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #8705      +/-   ##
==========================================
- Coverage   60.93%   60.84%   -0.10%     
==========================================
  Files        3792     3797       +5     
  Lines       90507    90671     +164     
  Branches    14209    14251      +42     
==========================================
+ Hits        55153    55168      +15     
- Misses      31868    32012     +144     
- Partials     3486     3491       +5     
Flag Coverage Δ
Linux_1 29.07% <8.69%> (-0.01%) ⬇️
Linux_2 56.53% <ø> (ø)
Linux_3 37.60% <7.04%> (-0.11%) ⬇️
Linux_4 29.95% <8.69%> (-0.01%) ⬇️
Windows_1 29.10% <8.69%> (+0.01%) ⬆️
Windows_2 56.49% <ø> (ø)
Windows_3 37.60% <7.04%> (-0.10%) ⬇️
Windows_4 29.95% <8.69%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving assuming ci passes

@ananzh ananzh merged commit a887cec into opensearch-project:2.x Oct 25, 2024
63 of 67 checks passed
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants